Bump dependencies, fix integration tests #227
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously pinned @vscode/test-electron package errored when downloading latest stable vscode build. Updating it as suggested in the comment fixes the issue - microsoft/vscode-test#255 (comment) * Updated @vscode/test-electron to the latest available version * Remove @vscode/test-electron version patch * Remove useless log in integration/runTests.ts
Integration tests are now fixed and can be included in pipeline. This reverts commit 44e45b1.
Ilanaya
commented
Jul 29, 2025
| @@ -231,5 +231,5 @@ | |||
| "runTest": false | |||
| } | |||
| }, | |||
| "packageManager": "pnpm@10.12.1+sha512.f0dda8580f0ee9481c5c79a1d927b9164f2c478e90992ad268bbb2465a736984391d6333d2c327913578b2804af33474ca554ba29c04a8b13060a717675ae3ac" | |||
| "packageManager": "pnpm@10.13.1" | |||
There was a problem hiding this comment.
@zardoy Why did you choose this specific pnpm build?
There was a problem hiding this comment.
Use corepack. Core pack automatically adds this field when any pnpm command is run. This was the latest pnpm build at that time
Comment on lines
+32
to
+34
| - uses: GabrielBB/[email protected] | ||
| with: | ||
| run: pnpm integration-test |
There was a problem hiding this comment.
I reverted the commit where you deleted the integration tests from the pipeline (see 774358a)
I think we should either delete integration tests entirely or add them to the pipeline.
|
Agree, doesn't really matter what way we go here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.