fix(clipboard-link-detection): don't spam with *Install packages?* notification on every windows focus

chore: enable typechecking for codebase on CI
chore: first unit test

Author: zardoy

.eslintrc.json

@@ -1,4 +1,6 @@
 {
     "extends": "zardoy",
-    "rules": {}
+    "rules": {
+        "@typescript-eslint/prefer-nullish-coalescing": "off"
+    }
 }

package.json

@@ -118,7 +118,7 @@
     "capabilities": {
         "untrustedWorkspaces": {
             "supported": false,
-            "description": "This extension needs to run arbitrary commands provided by package manager, installed on your system"
+            "description": "This extension needs to run arbitrary commands provided by package manager installed on your system"
         },
         "virtualWorkspaces": {
             "supported": "limited",
@@ -141,8 +141,9 @@
     ],
     "scripts": {
         "start": "vscode-framework start",
-        "build": "vscode-framework build --skip-typechecking",
-        "lint": "eslint src/**"
+        "build": "vscode-framework build",
+        "lint": "eslint src/**",
+        "test": "jest"
     },
     "devDependencies": {
         "@types/fs-extra": "^9.0.13",

src/autocompletion.ts

@@ -5,10 +5,14 @@ import { getPrefferedPackageManager, packageManagerCommand } from '../commands-c
 import { confirmAction, getCurrentWorkspaceRoot } from '../commands-core/util'
 
 export const registerClipboardDetection = () => {
+    let lastAskedClipboardString = null as string | null
     vscode.window.onDidChangeWindowState(async ({ focused }) => {
         if (!focused) return
         if (getExtensionSetting('install.clipboardDetection') === 'disabled') return
-        const clipboardText = (await vscode.env.clipboard.readText()).trim()
+        const clipboardText = await vscode.env.clipboard.readText().then(str => str.trim())
+        if (lastAskedClipboardString === clipboardText) return
+        // don't spam with messages on every window focus
+        lastAskedClipboardString = clipboardText
         const result = getPackagesFromInstallCmd(clipboardText)
         if (!result) return
 
@@ -28,19 +32,18 @@ export const registerClipboardDetection = () => {
 }
 
 export const getPackagesFromInstallCmd = (input: string) => {
-    // const regex = /^(npm|yarn|pnpm) (?:i|install|add)((?: (?:@[a-z\d~-][a-z\d._~-]*\/)?[a-z\d~-][a-z\d._~-]*)+)$/
+    // stricter regex: /^(npm|yarn|pnpm) (?:i|install|add)((?: (?:@[a-z\d~-][a-z\d._~-]*\/)?[a-z\d~-][a-z\d._~-]*)+)$/
     const result = /^(npm|yarn|pnpm) (?:i|install|add) (.+)$/.exec(input.trim())
     if (!result) return
     const packageManager = result[1]!
+    // space delimiter is fine, since package names can't have space within
     let [flags, packages] = partition(result[2]!.split(' '), value => value.startsWith('-'))
     const preserveFlags = new Set(['--global', '-g', '--ignore-scripts'])
     // lodash-marker
-    flags = flags.filter(flag => preserveFlags.has(flag) || flag.startsWith('--save') || ['dev', '-D'].includes(flag))
+    flags = flags.filter(flag => preserveFlags.has(flag) || flag.startsWith('--save') || ['--dev', '-D'].includes(flag))
     return {
         packageManager,
         packages,
         flags,
     }
 }
-
-const yarnStripSavePart = (input: string) => {}

src/core/clipboardDetection.test.ts

@@ -3,16 +3,15 @@ import { parseTree, getLocation } from 'jsonc-parser'
 import { getExtensionSetting } from 'vscode-framework'
 
 export const registerPackageJsonAutoComplete = () => {
-    if (true || !getExtensionSetting('scriptsCompletion')) return
-    vscode.languages.registerCompletionItemProvider('json', {
-        provideCompletionItems(document, position, token, context) {
-            if (!document.uri.path.endsWith('package.json')) return []
-
-            const offset = document.offsetAt(position)
-            const node = parseTree(document.getText())
-            if (!node) return
-            // getNdoeAtLocation
-            // console.log(getLocation(document.getText(), offset).matches(['scripts', '*']))
-        },
-    })
+    // if (true || !getExtensionSetting('scriptsCompletion')) return
+    // vscode.languages.registerCompletionItemProvider('json', {
+    //     provideCompletionItems(document, position, token, context) {
+    //         if (!document.uri.path.endsWith('package.json')) return []
+    //         const offset = document.offsetAt(position)
+    //         const node = parseTree(document.getText())
+    //         if (!node) return
+    //         // getNdoeAtLocation
+    //         // console.log(getLocation(document.getText(), offset).matches(['scripts', '*']))
+    //     },
+    // })
 }

src/core/clipboardDetection.ts

@@ -0,0 +1 @@
+module.exports = {}

src/packageJsonAutoComplete.ts

@@ -0,0 +1 @@
+module.exports = {}

test/__mocks__/fkill.js

@@ -0,0 +1,61 @@
+/// <reference types="jest" />
+import { getPackagesFromInstallCmd } from '../src/core/clipboardDetection'
+
+describe('getPackagesFromInstallCmd', () => {
+    test('0', () => {
+        expect(getPackagesFromInstallCmd('npm i foo')).toMatchInlineSnapshot(`
+Object {
+  "flags": Array [],
+  "packageManager": "npm",
+  "packages": Array [
+    "foo",
+  ],
+}
+`)
+    })
+    test('1', () => {
+        expect(getPackagesFromInstallCmd('npm i foo --dev bar --dangerous-flag foo -D some-another-package')).toMatchInlineSnapshot(`
+Object {
+  "flags": Array [
+    "--dev",
+    "-D",
+  ],
+  "packageManager": "npm",
+  "packages": Array [
+    "foo",
+    "bar",
+    "foo",
+    "some-another-package",
+  ],
+}
+`)
+    })
+    test('2', () => {
+        expect(getPackagesFromInstallCmd('yarn add "test" --dev')).toMatchInlineSnapshot(`
+Object {
+  "flags": Array [
+    "--dev",
+  ],
+  "packageManager": "yarn",
+  "packages": Array [
+    "\\"test\\"",
+  ],
+}
+`)
+    })
+    test('3', () => {
+        expect(getPackagesFromInstallCmd('pnpm install "test" --save-dev -foo "-d" 83')).toMatchInlineSnapshot(`
+Object {
+  "flags": Array [
+    "--save-dev",
+  ],
+  "packageManager": "pnpm",
+  "packages": Array [
+    "\\"test\\"",
+    "\\"-d\\"",
+    "83",
+  ],
+}
+`)
+    })
+})

test/__mocks__/vscode.js

@@ -1,4 +1,5 @@
 {
     "extends": "@zardoy/tsconfig/node",
-    "include": ["src"]
+    "include": ["src"],
+    "exclude": ["src/webview"]
 }