fix: now openPackageRepository command is using almost 1:1 npm repo implementation. The only difference is that it will use master instead of HEAD in url branch.

fix: disable `codeAction.resolveBranchName` by default (performance-first)

Author: zardoy

src/commands/npmOpenRepository.ts

@@ -0,0 +1,44 @@
+import hostedGitInfo from 'hosted-git-info'
+
+export const getPackageRepositoryUrl = (spec, { repository }, handleDirectory) => {
+    const r = repository
+    const rurl = r ? (typeof r === 'string' ? r : typeof r === 'object' && typeof r.url === 'string' ? r.url : null) : null
+
+    if (!rurl)
+        throw Object.assign(new Error('no repository'), {
+            pkgid: spec,
+        })
+
+    const info = hostedFromMani({ repository })
+    const url = info ? info.browse(handleDirectory ? repository.directory : undefined) : unknownHostedUrl(rurl)
+
+    if (!url)
+        throw Object.assign(new Error('no repository: could not get url'), {
+            pkgid: spec,
+        })
+
+    return url
+}
+
+const hostedFromMani = ({ repository }) => {
+    const r = repository
+    const rurl = r ? (typeof r === 'string' ? r : typeof r === 'object' && typeof r.url === 'string' ? r.url : null) : null
+
+    // hgi returns undefined sometimes, but let's always return null here
+    return (rurl && hostedGitInfo.fromUrl(rurl.replace(/^git\+/, ''))) || null
+}
+
+const unknownHostedUrl = url => {
+    try {
+        const { protocol, hostname, pathname } = new URL(url)
+
+        /* istanbul ignore next - URL ctor should prevent this */
+        if (!protocol || !hostname) return null
+
+        const proto = /(git\+)http:$/.test(protocol) ? 'http:' : 'https:'
+        const path = pathname.replace(/\.git$/, '')
+        return `${proto}//${hostname}${path}`
+    } catch {
+        return null
+    }
+}

src/commands/openPackageAt.ts

@@ -1,11 +1,11 @@
 import * as vscode from 'vscode'
 import defaultBranch from 'default-branch'
-import { fromUrl } from 'hosted-git-info'
 import { getExtensionCommandId, getExtensionSetting, registerExtensionCommand, RegularCommands, showQuickPick } from 'vscode-framework'
 import { getCurrentWorkspaceRoot } from '@zardoy/vscode-utils/build/fs'
 import { noCase } from 'change-case'
 import { findUpNodeModules, pickInstalledDeps, readDirPackageJson } from '../commands-core/packageJson'
 import { joinPackageJson, supportedFileSchemes } from '../commands-core/util'
+import { getPackageRepositoryUrl } from './npmOpenRepository'
 
 /** get module dir URI from closest node_modules */
 const getClosestModulePath = async (module: string, path = '') => {
@@ -53,38 +53,34 @@ export const registerOpenPackageAtCommands = () => {
         if (!module) module = await pickInstalledDeps({ commandId, multiple: false, flatTypes: false })
         if (module === undefined) return
         const cwd = await getClosestModulePath(module)
-        let { repository } = await readDirPackageJson(cwd)
+        const manifest = await readDirPackageJson(cwd)
+        const { repository } = manifest
         if (!repository) {
             // TODO try to resolve url automatically
             const action = await vscode.window.showWarningMessage(`${module} doesn't have repository field`, 'Open on NPM')
             if (action === 'Open on NPM') await vscode.commands.executeCommand(getExtensionCommandId('openOnNpm'), module)
             return
         }
 
-        // TODO use lib from vsce
-        // TODO support just url
-        let repoDir: string | undefined
-        if (typeof repository === 'object') {
-            repoDir = repository.directory
-            repository = repository.url
-        }
-
-        const repo = fromUrl(repository)!
-        let urlPath = ''
-        if (repo.domain === 'github.com' && repoDir) {
-            let branchName: string
+        const handlePathManually = typeof repository === 'object' && repository.url.startsWith('https://github.com/') && repository.directory
+        let openPath = ''
+        if (handlePathManually) {
+            let branchName = 'master'
             if (getExtensionSetting('codeAction.resolveBranchName')) {
-                console.time('get branch')
-                branchName = await defaultBranch(`${repo.user}/${repo.project}`)
-                console.timeEnd('get branch')
-            } else {
-                branchName = 'master'
+                console.time('get repo github branch')
+                branchName = await defaultBranch(repository.url)
+                console.timeEnd('get repo github branch')
             }
 
-            urlPath = `/tree/${branchName}/${repoDir}`
+            openPath = `/tree/${branchName}/${repository.directory!.replace(/^\//, '')}`
         }
 
-        await vscode.env.openExternal((repo.browse() + urlPath) as any)
+        try {
+            const url: string = getPackageRepositoryUrl(module, { repository }, !handlePathManually)
+            await vscode.commands.executeCommand('vscode.open', url.replace(/\/$/, '') + openPath)
+        } catch (err) {
+            await vscode.window.showWarningMessage(err.message ?? err.stack)
+        }
     })
 
     registerExtensionCommand('revealInExplorer', async ({ command: commandId }, module?: string) => {

src/configurationType.ts

@@ -212,7 +212,7 @@ export type Configuration = {
     'yarnBerry.workspaceAutoInstall': boolean
     /**
      * Disable if action open repository takes a lot of time, in this case it would use `master` branch in url
-     * @default true
+     * @default false
      */
     'codeAction.resolveBranchName': boolean
     runOnSave: RunOnSaveRule[]

src/configurationTypeCache.jsonc

@@ -1,5 +1,5 @@
 // GENERATED. DON'T EDIT MANUALLY
-// md5hash: b133959f2da203c7532b20a88fa054bf
+// md5hash: a615e5beebf47dae76bfdc05804435e9
 {
     "type": "object",
     "properties": {
@@ -191,7 +191,7 @@
         },
         "codeAction.resolveBranchName": {
             "description": "Disable if action open repository takes a lot of time, in this case it would use `master` branch in url",
-            "default": true,
+            "default": false,
             "type": "boolean"
         },
         "runOnSave": {