fix: bin completions & run bin command now scans all folders in fs up to the root

it was fixed to make it work in files outside of any workspace

Author: zardoy

package.json

@@ -228,5 +228,14 @@
         "vscode-uri": "^3.0.3",
         "which-pm": "^2.0.0",
         "yamljs": "^0.3.0"
+    },
+    "prettier": {
+        "semi": false,
+        "singleQuote": true,
+        "proseWrap": "never",
+        "tabWidth": 4,
+        "trailingComma": "all",
+        "arrowParens": "avoid",
+        "printWidth": 160
     }
 }

src/commands/runBinCommand.ts

@@ -29,31 +29,27 @@ export const runBinCommand = async () => {
 }
 
 export const getBinCommands = async () => {
-    const documentPath = vscode.window.activeTextEditor?.document.uri.fsPath
-    const workspacePath = vscode.workspace.workspaceFolders?.[0]!.uri.fsPath
-    if (!workspacePath) throw new Error('available only in workspace')
+    const _docUri = vscode.window.activeTextEditor?.document.uri
+    if (!_docUri) return []
+    const folderUri = vscode.Uri.joinPath(_docUri, '..')
+    const workspaceUri = vscode.workspace.workspaceFolders?.[0]!.uri
+    const isFileInWorkspace = !workspaceUri || folderUri.toString().startsWith(workspaceUri.toString())
 
     const nodeModulesPaths = await (async () => {
-        if (documentPath) {
-            const findUpArgs = [
-                'node_modules',
-                {
-                    cwd: documentPath,
-                    stopAt: workspacePath,
-                    type: 'directory',
-                },
-            ] as const
-            if (getExtensionSetting('runBinCommand.searchLocation') === 'nearest') {
-                const path = await findUp(...findUpArgs)
-                return path !== undefined && [path]
-            }
-
-            return findUpMultiple(...findUpArgs)
+        const findUpArgs = [
+            'node_modules',
+            {
+                cwd: folderUri.fsPath,
+                stopAt: isFileInWorkspace ? workspaceUri!.fsPath : undefined,
+                type: 'directory',
+            },
+        ] as const
+        if (getExtensionSetting('runBinCommand.searchLocation') === 'nearest') {
+            const path = await findUp(...findUpArgs)
+            return path !== undefined && [path]
         }
 
-        const nodeModulesPath = join(workspacePath, 'node_modules')
-        if (fs.existsSync(nodeModulesPath)) return [nodeModulesPath]
-        return []
+        return findUpMultiple(...findUpArgs)
     })()
     if (!nodeModulesPaths || nodeModulesPaths.length === 0) throw new Error('no node_modules in current workspace')
 

src/configurationType.ts

@@ -152,6 +152,9 @@ export type Configuration = {
     //     "All bin commands from all node_modules from cwd up to root of workspace",
     //     "All bin commands from nearest node_modules"
     // ]
+    /**
+     * @default allUpToRoot
+     */
     'runBinCommand.searchLocation': 'allUpToRoot' | 'nearest'
     // 'editor.suggestPackagesToInstall': { [identifier: string]: boolean }
     /**

src/configurationTypeCache.jsonc

@@ -1,5 +1,5 @@
 // GENERATED. DON'T EDIT MANUALLY
-// md5hash: fd6807fee82c0259817e00d5a0a9b619
+// md5hash: 90717a6b6c67a68e25ab99d99671936f
 {
     "type": "object",
     "properties": {
@@ -145,7 +145,6 @@
             "type": "boolean"
         },
         "runBinCommand.searchLocation": {
-            "description": "From where to pick bin commands",
             "default": "allUpToRoot",
             "enum": [
                 "allUpToRoot",

src/packageJsonComplete.ts

@@ -23,14 +23,13 @@ export const registerPackageJsonCompletions = () => {
                 const root = parseTree(document.getText())!
                 const location = getLocation(document.getText(), offset)
                 const { path } = location
-                const node = findNodeAtLocation(root, path)
                 const jsonCompletingInfo = getJsonCompletingInfo(location, document, position)
                 if (!jsonCompletingInfo) return
                 const { insideStringRange } = jsonCompletingInfo
-                const folder = Utils.joinPath(document.uri, '..')
+                const folderUri = Utils.joinPath(document.uri, '..')
                 if (insideStringRange) {
                     if (location.matches(['name'])) {
-                        const folderName = Utils.basename(folder)
+                        const folderName = Utils.basename(folderUri)
                         return jsonValuesToCompletions([folderName])
                     }
 
@@ -74,7 +73,7 @@ export const registerPackageJsonCompletions = () => {
                             compareString = compareString.replace(/\s$/, '')
                             for (const [key, filesGlob] of Object.entries(pathAutoComplete))
                                 if (compareString === key) {
-                                    const files = await vscode.workspace.findFiles(new vscode.RelativePattern(folder, filesGlob), '**/node_modules/**')
+                                    const files = await vscode.workspace.findFiles(new vscode.RelativePattern(folderUri, filesGlob), '**/node_modules/**')
                                     return files.map(uri => ({
                                         label: Utils.basename(uri),
                                         kind: vscode.CompletionItemKind.File,
@@ -106,12 +105,9 @@ export const registerPackageJsonCompletions = () => {
                             }),
                         )
                     }
-                    //
                 }
 
                 // if (location.matches(['peerDependenciesMeta'])) return jsonValuesToCompletions(['test'])
-
-                // console.log(getLocation(document.getText(), offset).matches(['scripts', '*']))
                 return undefined
             },
         },