fix: restored default value of scripts.mainScripts

feat: add leadingPackageManager setting that allows you specify pm that will be used by default with extremely sane default
fix: add output piping for pnpm commands
fix: it seems commands (incluing pnpm) are now cancellable!

Author: zardoy

package.json

@@ -171,6 +171,7 @@
         "execa": "^5.1.1",
         "filesize": "^8.0.7",
         "find-up": "^6.2.0",
+        "fkill": "^8.0.0",
         "fs-extra": "^10.0.0",
         "globby": "^11.1.0",
         "got": "^11.8.3",

pnpm-lock.yaml

@@ -1,7 +1,7 @@
 import { posix } from 'path'
 import vscode from 'vscode'
 import yamlJs from 'yamljs'
-import { SupportedPackageManagersNames } from '../core/packageManager'
+import { SupportedPackageManagersName } from '../core/packageManager'
 import { readDirPackageJson } from './packageJson'
 import { fsExists } from './util'
 import { getPrefferedPackageManager } from './packageManager'
@@ -22,7 +22,7 @@ export const getPmFolders = async () => {
         return undefined
     }
 
-    const monorepoProviders: Record<SupportedPackageManagersNames, (cwd: vscode.Uri) => Promise<{ patterns: string[] } | void>> = {
+    const monorepoProviders: Record<SupportedPackageManagersName, (cwd: vscode.Uri) => Promise<{ patterns: string[] } | void>> = {
         npm: getYarnWorkspaces,
         yarn: getYarnWorkspaces,
         async pnpm(cwd) {

src/commands-core/getPmFolders.ts

@@ -1,10 +1,10 @@
 import vscode from 'vscode'
 import execa from 'execa'
-import { GracefulCommandError } from 'vscode-framework'
-import { pnpmCommand, supportedPackageManagers, SupportedPackageManagersNames } from '../core/packageManager'
+import { getExtensionSetting, GracefulCommandError } from 'vscode-framework'
+import { pnpmCommand, supportedPackageManagers, SupportedPackageManagersName } from '../core/packageManager'
 import { firstExists } from './util'
 
-export const getPrefferedPackageManager = async (cwd: vscode.Uri): Promise<SupportedPackageManagersNames> => {
+export const getPrefferedPackageManager = async (cwd: vscode.Uri): Promise<SupportedPackageManagersName> => {
     let preffereddFromNpm = vscode.workspace.getConfiguration('npm').get<string>('packageManager')
     if (preffereddFromNpm === 'auto') preffereddFromNpm = undefined
     // TODO move it to bottom and always use workspace client
@@ -15,19 +15,30 @@ export const getPrefferedPackageManager = async (cwd: vscode.Uri): Promise<Suppo
             uri: vscode.Uri.joinPath(cwd, detectFile),
         })),
     )
-    // TODO why npm
-    return name ?? 'npm'
+    const leadingPackageManager = getExtensionSetting('leadingPackageManager')
+    if (name) return name
+    if (leadingPackageManager !== null) return leadingPackageManager
+    let pm: SupportedPackageManagersName = 'npm' // will be used last
+    // TODO check also version
+
+    for (const pmToCheck of ['pnpm', 'yarn'] as SupportedPackageManagersName[])
+        if (await getPmVersion(pmToCheck)) {
+            pm = pmToCheck
+            break
+        }
+
+    return pm
 }
 
-export const getPmVersion = async (pm: SupportedPackageManagersNames) => {
+export const getPmVersion = async (pm: SupportedPackageManagersName) => {
     try {
         return (await execa(pm, ['--version'])).stdout
     } catch {
         return undefined
     }
 }
 
-export const pmIsInstalledOrThrow = async (pm: SupportedPackageManagersNames) => {
+export const pmIsInstalledOrThrow = async (pm: SupportedPackageManagersName) => {
     const version = await getPmVersion(pm)
     if (!version) {
         if (pm === 'npm')
@@ -66,7 +77,7 @@ export const packageManagerCommand = async ({
     // TODO combine them
     // cancellationToken?: vscode.CancellationToken
     packages?: string[]
-    forcePm?: SupportedPackageManagersNames
+    forcePm?: SupportedPackageManagersName
     // flags?: {
     //     global: boolean
     //     dev: boolean
@@ -95,8 +106,9 @@ export const packageManagerCommand = async ({
     }
 
     if (typeof flags === 'string') flags = flags.split(' ')
+    let execCmd = command
     if (command === 'install') {
-        command = supportedPackageManagers[pm].installCommand as any
+        execCmd = supportedPackageManagers[pm].installCommand as any
     } else if (packages.length === 0) {
         void vscode.window.showWarningMessage(`No packages to ${command} provided`)
         return
@@ -113,14 +125,14 @@ export const packageManagerCommand = async ({
                 case 'npm':
                 case 'yarn':
                     // TODO yarn --json
-                    await execa(pm, [command, ...(packages ?? []), ...flags], {
+                    await execa(pm, [execCmd, ...(packages ?? []), ...flags], {
                         cwd: cwd.fsPath,
                     })
                     break
                 case 'pnpm':
                     await pnpmCommand({
                         cwd: cwd.fsPath,
-                        command,
+                        command: execCmd,
                         cancellationToken,
                         packages,
                         reportProgress,

src/commands-core/packageManager.ts

@@ -5,6 +5,14 @@
 // },
 // enforcePackageManagerUse
 export type Configuration = {
+    // TOOD describe difference between builtin setting
+    /**
+     * Your main package manager that leads your projects
+     * Used when no lockfile is detected
+     * By default (when null) first installed is picked: pnpm, yarn, npm
+     * @default null
+     * */
+    leadingPackageManager: 'pnpm' | 'yarn' | 'npm' | null
     /**
      * What to do on clipboard detection for copied command to install packages
      * @default ask
@@ -60,6 +68,15 @@ export type Configuration = {
      * @default true
      */
     'addPackages.installTypes': boolean
+    /**
+     * The first script will be run from this list on `start-npm-script` command.
+     * @uniqueItems true
+     * @default [
+            "dev",
+            "start",
+            "watch"
+        ]
+     */
     'scripts.mainScripts': string[]
     /**
      * Whether to match script contents in quickpick search

src/configurationType.ts

@@ -1,8 +1,18 @@
 // GENERATED. DON'T EDIT MANUALLY
-// md5hash: 1a8290bf7111a243e1fb57982d76c654
+// md5hash: 556480798888bbc8df856f9dbf22165a
 {
     "type": "object",
     "properties": {
+        "leadingPackageManager": {
+            "description": "Your main package manager that leads your projects\nUsed when no lockfile is detected\nBy default (when null) first installed is picked: pnpm, yarn, npm",
+            "default": null,
+            "enum": [
+                "npm",
+                "pnpm",
+                "yarn"
+            ],
+            "type": "string"
+        },
         "install.clipboardDetection": {
             "description": "What to do on clipboard detection for copied command to install packages",
             "default": "ask",
@@ -59,6 +69,13 @@
             "type": "boolean"
         },
         "scripts.mainScripts": {
+            "description": "The first script will be run from this list on `start-npm-script` command.",
+            "uniqueItems": true,
+            "default": [
+                "dev",
+                "start",
+                "watch"
+            ],
             "type": "array",
             "items": {
                 "type": "string"
@@ -128,6 +145,7 @@
         "install.watchDelay",
         "install.watchPackageJson",
         "install.watchPackageLocks",
+        "leadingPackageManager",
         "runBinCommand.searchLocation",
         "scripts.mainScripts",
         "scripts.matchContents",

src/configurationTypeCache.jsonc

@@ -8,10 +8,8 @@ export const registerClipboardDetection = () => {
     vscode.window.onDidChangeWindowState(async ({ focused }) => {
         if (!focused) return
         if (getExtensionSetting('install.clipboardDetection') === 'disabled') return
-        console.time('detect')
         const clipboardText = (await vscode.env.clipboard.readText()).trim()
         const result = getPackagesFromInstallCmd(clipboardText)
-        console.timeEnd('detect')
         if (!result) return
 
         // TODO