Merge pull request #6573 from psiinon/error-stacktrace

kingthorin · web-flow · commit edca3ce87929 · 2025-07-08T10:54:45.000-04:00
Error logs to always include stack trace.
diff --git a/addOns/ascanrulesBeta/CHANGELOG.md b/addOns/ascanrulesBeta/CHANGELOG.md
@@ -7,6 +7,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Changed
 - Depends on an updated version of the Common Library add-on.
 
+### Fixed
+- Error logs to always include stack trace.
+
 ### Added
 - Rules (as applicable) have been tagged in relation to HIPAA and PCI DSS.
 - The 403 Bypass scan rule now has a CWE reference.
diff --git a/addOns/ascanrulesBeta/src/main/java/org/zaproxy/zap/extension/ascanrulesBeta/CsrfTokenScanRule.java b/addOns/ascanrulesBeta/src/main/java/org/zaproxy/zap/extension/ascanrulesBeta/CsrfTokenScanRule.java
@@ -243,7 +243,7 @@ public void scan() {
                 formIdx++;
             }
         } catch (IOException e) {
-            LOGGER.error(e);
+            LOGGER.debug(e, e);
         }
     }
 
diff --git a/addOns/bruteforce/CHANGELOG.md b/addOns/bruteforce/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## Unreleased
 
+### Fixed
+- Error logs to always include stack trace.
 
 ## [17] - 2025-01-09
 ### Changed
diff --git a/addOns/bruteforce/src/main/java/com/sittinglittleduck/DirBuster/Manager.java b/addOns/bruteforce/src/main/java/com/sittinglittleduck/DirBuster/Manager.java
@@ -434,7 +434,7 @@ else if (urlFuzz) {
             }
 
         } catch (Exception e) {
-            LOGGER.error(e);
+            LOGGER.error(e, e);
         }
     }
 
diff --git a/addOns/bruteforce/src/main/java/com/sittinglittleduck/DirBuster/workGenerators/BruteForceURLFuzz.java b/addOns/bruteforce/src/main/java/com/sittinglittleduck/DirBuster/workGenerators/BruteForceURLFuzz.java
@@ -97,7 +97,7 @@ public void run() {
                     manager.setAuto(false);
                 }
             } catch (IOException e) {
-                LOGGER.error(e);
+                LOGGER.error(e, e);
             }
         }
 
@@ -108,7 +108,7 @@ public void run() {
             // get dir name
             currentDir = tempDirToCheck.getName();
         } catch (InterruptedException e) {
-            LOGGER.debug(e);
+            LOGGER.debug(e, e);
         }
 
         LOGGER.info("Starting fuzz on {}{}{dir}{}", firstPart, urlFuzzStart, urlFuzzEnd);
@@ -125,7 +125,7 @@ public void run() {
                     GenBaseCase.genURLFuzzBaseCase(manager, firstPart + urlFuzzStart, urlFuzzEnd);
 
         } catch (IOException e) {
-            LOGGER.error(e);
+            LOGGER.error(e, e);
         }
 
         // baseCaseObj = new BaseCase(null, failcode, true, failurl, baseCase);
diff --git a/addOns/bruteforce/src/main/java/com/sittinglittleduck/DirBuster/workGenerators/BruteForceWorkGenerator.java b/addOns/bruteforce/src/main/java/com/sittinglittleduck/DirBuster/workGenerators/BruteForceWorkGenerator.java
@@ -109,7 +109,7 @@ public void run() {
                     manager.setAuto(false);
                 }
             } catch (IOException e) {
-                LOGGER.error(e);
+                LOGGER.error(e, e);
             }
         }
 
@@ -124,7 +124,7 @@ public void run() {
                 // get any extention that need to be checked
                 extToCheck = tempDirToCheck.getExts();
             } catch (InterruptedException e) {
-                LOGGER.debug(e);
+                LOGGER.debug(e, e);
             }
 
             started = currentDir;
@@ -142,7 +142,7 @@ public void run() {
                             GenBaseCase.genBaseCase(manager, firstPart + currentDir, true, null);
 
                 } catch (IOException e) {
-                    LOGGER.error(e);
+                    LOGGER.error(e, e);
                 }
 
                 // baseCaseObj = new BaseCase(null, failcode, true, failurl, baseCase);
@@ -178,7 +178,7 @@ public void run() {
                                             manager, firstPart + currentDir, false, fileExtention);
 
                         } catch (IOException e) {
-                            LOGGER.error(e);
+                            LOGGER.error(e, e);
                         }
 
                         // call function to generate the brute force
diff --git a/addOns/bruteforce/src/main/java/com/sittinglittleduck/DirBuster/workGenerators/WorkerGenerator.java b/addOns/bruteforce/src/main/java/com/sittinglittleduck/DirBuster/workGenerators/WorkerGenerator.java
@@ -106,7 +106,7 @@ public void run() {
         } catch (FileNotFoundException ex) {
             LOGGER.error("File '{}' not found!", inputFile, ex);
         } catch (IOException ex) {
-            LOGGER.error(ex);
+            LOGGER.error(ex, ex);
         }
         // -------------------------------------------------
 
@@ -133,7 +133,7 @@ public void run() {
                     manager.setAuto(false);
                 }
             } catch (IOException e) {
-                LOGGER.error(e);
+                LOGGER.error(e, e);
             }
         }
 
@@ -178,7 +178,7 @@ public void run() {
                     baseCaseObj =
                             GenBaseCase.genBaseCase(manager, firstPart + currentDir, true, null);
                 } catch (IOException e) {
-                    LOGGER.error(e);
+                    LOGGER.error(e, e);
                 }
 
                 // end of dir fail case
@@ -278,7 +278,7 @@ public void run() {
                 } catch (FileNotFoundException e) {
                     LOGGER.error("File '{}' not found!", inputFile, e);
                 } catch (IOException e) {
-                    LOGGER.error(e);
+                    LOGGER.error(e, e);
                 }
             }
 
@@ -308,7 +308,7 @@ public void run() {
                                     GenBaseCase.genBaseCase(
                                             manager, firstPart + currentDir, false, fileExtention);
                         } catch (IOException e) {
-                            LOGGER.error(e);
+                            LOGGER.error(e, e);
                         }
 
                         // if the manager has sent the stop command then exit
@@ -380,7 +380,7 @@ public void run() {
                         } catch (FileNotFoundException e) {
                             LOGGER.error("File '{}' not found!", inputFile, e);
                         } catch (IOException e) {
-                            LOGGER.error(e);
+                            LOGGER.error(e, e);
                         }
                     }
                 } // end of file ext loop
diff --git a/addOns/bruteforce/src/main/java/org/zaproxy/zap/extension/bruteforce/BruteForcePanel.java b/addOns/bruteforce/src/main/java/org/zaproxy/zap/extension/bruteforce/BruteForcePanel.java
@@ -676,7 +676,7 @@ protected void bruteForceDirectoryAndChildren(SiteNode node) {
                                 .getPath();
                 startScan(dir, true);
             } catch (Exception e) {
-                LOGGER.error(e);
+                LOGGER.error(e, e);
             }
         }
     }
diff --git a/addOns/client/CHANGELOG.md b/addOns/client/CHANGELOG.md
@@ -10,6 +10,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Changed
 - Updated Chrome and Firefox extensions to v0.1.4.
 
+### Fixed
+- Error logs to always include stack trace.
 
 ## [0.16.0] - 2025-06-20
 ### Added
diff --git a/addOns/client/src/main/java/org/zaproxy/addon/client/spider/ClientSpider.java b/addOns/client/src/main/java/org/zaproxy/addon/client/spider/ClientSpider.java
@@ -906,7 +906,7 @@ private void notifyMessage(HttpMessage httpMessage, int historyType, ResourceSta
                             messagesTableModel.addHistoryReference(historyRef, state);
                         });
             } catch (HttpMalformedHeaderException | DatabaseException e) {
-                LOGGER.error(e);
+                LOGGER.error(e, e);
             }
         }
     }
diff --git a/addOns/llm/CHANGELOG.md b/addOns/llm/CHANGELOG.md
@@ -7,3 +7,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Added
 - Allow to perform API sequencing and alert review.
 - Basic stats
+
+### Fixed
+- Error logs to always include stack trace.
diff --git a/addOns/llm/src/main/java/org/zaproxy/addon/llm/ui/LlmReviewAlertMenu.java b/addOns/llm/src/main/java/org/zaproxy/addon/llm/ui/LlmReviewAlertMenu.java
@@ -55,7 +55,7 @@ public void performAction(Alert alert) {
         } catch (Exception e) {
             View.getSingleton()
                     .showWarningDialog(Constant.messages.getString("llm.reviewalert.error"));
-            LOGGER.error(e);
+            LOGGER.error(e, e);
         }
     }
 
diff --git a/addOns/openapi/CHANGELOG.md b/addOns/openapi/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## Unreleased
 
+### Fixed
+- Warn logs to always include stack trace.
 
 ## [45] - 2025-03-24
 ### Fixed
diff --git a/addOns/openapi/src/main/java/org/zaproxy/zap/extension/openapi/TableOpenApi.java b/addOns/openapi/src/main/java/org/zaproxy/zap/extension/openapi/TableOpenApi.java
@@ -88,7 +88,7 @@ private static void increaseDefinitionColumnSize(Connection conn) {
             int columnSize = DbUtils.getColumnSize(conn, "OPENAPI_SPECS", "DEFINITION");
             LOGGER.debug("Definition column size is now: {}", columnSize);
         } catch (SQLException e) {
-            LOGGER.warn(e);
+            LOGGER.warn(e, e);
         }
     }
 
diff --git a/addOns/paramdigger/CHANGELOG.md b/addOns/paramdigger/CHANGELOG.md
@@ -7,6 +7,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Changed
 - Update minimum ZAP version to 2.16.0.
 
+### Fixed
+- Error logs to always include stack trace.
+
 ## [0.3.0] - 2024-07-15
 ### Added
 - Support for menu weights (Issue 8369)
diff --git a/addOns/paramdigger/src/main/java/org/zaproxy/addon/paramdigger/Utils.java b/addOns/paramdigger/src/main/java/org/zaproxy/addon/paramdigger/Utils.java
@@ -52,7 +52,7 @@ public static List<String> read(Path path) {
                 params.add(StringUtils.strip(line));
             }
         } catch (Exception e) {
-            LOGGER.error(e);
+            LOGGER.error(e, e);
         }
         return params;
     }
diff --git a/addOns/saml/CHANGELOG.md b/addOns/saml/CHANGELOG.md
@@ -8,6 +8,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Update minimum ZAP version to 2.16.0.
 - Maintenance changes.
 
+### Fixed
+- Error logs to always include stack trace.
+
 ## [10] - 2022-10-28
 ### Changed
 - Update minimum ZAP version to 2.12.0.
diff --git a/addOns/saml/src/main/java/org/zaproxy/zap/extension/saml/SAMLUtils.java b/addOns/saml/src/main/java/org/zaproxy/zap/extension/saml/SAMLUtils.java
@@ -182,7 +182,7 @@ public static String extractSAMLMessage(String val, Binding binding) {
                     break;
             }
         } catch (UnsupportedEncodingException | SAMLException e) {
-            LOGGER.error(e);
+            LOGGER.error(e, e);
         }
         return "";
     }
diff --git a/addOns/scripts/CHANGELOG.md b/addOns/scripts/CHANGELOG.md
@@ -7,6 +7,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Changed
 - Update help with newer JavaScript engine and links.
 
+### Fixed
+- Error logs to always include stack trace.
+
 ## [45.12.0] - 2025-06-20
 ### Changed
 - Maintenance changes.
diff --git a/addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/automation/actions/RunScriptAction.java b/addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/automation/actions/RunScriptAction.java
@@ -225,7 +225,7 @@ public void runJob(String jobName, AutomationEnvironment env, AutomationProgress
                 reportScriptError(progress, jobName, parameters, script.getLastException());
             }
         } catch (Exception e) {
-            LOGGER.error(e);
+            LOGGER.error(e, e);
             reportScriptError(progress, jobName, parameters, e);
         } finally {
             extScript.removeScriptOutputListener(scriptJobOutputListener);
diff --git a/addOns/spiderAjax/CHANGELOG.md b/addOns/spiderAjax/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## Unreleased
 
+### Fixed
+- Error logs to always include stack trace.
 
 ## [23.24.0] - 2025-06-20
 ### Added
diff --git a/addOns/spiderAjax/src/main/java/org/zaproxy/zap/extension/spiderAjax/AjaxSpiderAPI.java b/addOns/spiderAjax/src/main/java/org/zaproxy/zap/extension/spiderAjax/AjaxSpiderAPI.java
@@ -540,7 +540,7 @@ private void startScan(
         try {
             new Thread(spiderThread, "ZAP-AjaxSpiderApi").start();
         } catch (Exception e) {
-            LOGGER.error(e);
+            LOGGER.error(e, e);
         }
     }
 
diff --git a/addOns/spiderAjax/src/main/java/org/zaproxy/zap/extension/spiderAjax/SpiderPanel.java b/addOns/spiderAjax/src/main/java/org/zaproxy/zap/extension/spiderAjax/SpiderPanel.java
@@ -397,7 +397,7 @@ public void startScan(String displayName, AjaxSpiderTarget target, SpiderListene
         try {
             new Thread(runnable, "ZAP-AjaxSpider").start();
         } catch (Exception e) {
-            LOGGER.error(e);
+            LOGGER.error(e, e);
         }
     }
 
diff --git a/addOns/spiderAjax/src/main/java/org/zaproxy/zap/extension/spiderAjax/SpiderThread.java b/addOns/spiderAjax/src/main/java/org/zaproxy/zap/extension/spiderAjax/SpiderThread.java
@@ -515,7 +515,7 @@ private void notifyMessage(
 
             notifySpiderListenersFoundMessage(historyRef, httpMessage, state);
         } catch (Exception e) {
-            LOGGER.error(e);
+            LOGGER.error(e, e);
         }
     }
 
diff --git a/addOns/websocket/CHANGELOG.md b/addOns/websocket/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## Unreleased
 
+### Fixed
+- Error logs to always include stack trace.
 
 ## [33] - 2025-06-20
 ### Changed
diff --git a/addOns/websocket/src/main/java/org/zaproxy/zap/extension/websocket/WebSocketProxyV13.java b/addOns/websocket/src/main/java/org/zaproxy/zap/extension/websocket/WebSocketProxyV13.java
@@ -512,13 +512,13 @@ private byte[] getReadableCloseFramePayload(byte[] payload, int statusCode) {
             try {
                 System.arraycopy(closeCode, 0, newPayload, 0, closeCode.length);
             } catch (IndexOutOfBoundsException e) {
-                LOGGER.error(e);
+                LOGGER.error(e, e);
             }
 
             try {
                 System.arraycopy(payload, 2, newPayload, closeCode.length, payload.length - 2);
             } catch (IndexOutOfBoundsException e) {
-                LOGGER.error(e);
+                LOGGER.error(e, e);
             }
 
             return newPayload;
diff --git a/addOns/websocket/src/main/java/org/zaproxy/zap/extension/websocket/brk/WebSocketProxyListenerBreak.java b/addOns/websocket/src/main/java/org/zaproxy/zap/extension/websocket/brk/WebSocketProxyListenerBreak.java
@@ -133,7 +133,7 @@ private void setPayload(WebSocketMessage message, Object payload) {
                 message.setPayload((byte[]) payload);
             }
         } catch (WebSocketException e) {
-            LOGGER.error(e);
+            LOGGER.error(e, e);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ public void scan() {`
`243`	`243`	`formIdx++;`
`244`	`244`	`}`
`245`	`245`	`} catch (IOException e) {`
`246`		`- LOGGER.error(e);`
	`246`	`+ LOGGER.debug(e, e);`
`247`	`247`	`}`
`248`	`248`	`}`
`249`	`249`
Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,7 @@ else if (urlFuzz) {`
`434`	`434`	`}`
`435`	`435`
`436`	`436`	`} catch (Exception e) {`
`437`		`- LOGGER.error(e);`
	`437`	`+ LOGGER.error(e, e);`
`438`	`438`	`}`
`439`	`439`	`}`
`440`	`440`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ public void run() {`
`97`	`97`	`manager.setAuto(false);`
`98`	`98`	`}`
`99`	`99`	`} catch (IOException e) {`
`100`		`- LOGGER.error(e);`
	`100`	`+ LOGGER.error(e, e);`
`101`	`101`	`}`
`102`	`102`	`}`
`103`	`103`
`@@ -108,7 +108,7 @@ public void run() {`
`108`	`108`	`// get dir name`
`109`	`109`	`currentDir = tempDirToCheck.getName();`
`110`	`110`	`} catch (InterruptedException e) {`
`111`		`- LOGGER.debug(e);`
	`111`	`+ LOGGER.debug(e, e);`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`LOGGER.info("Starting fuzz on {}{}{dir}{}", firstPart, urlFuzzStart, urlFuzzEnd);`
`@@ -125,7 +125,7 @@ public void run() {`
`125`	`125`	`GenBaseCase.genURLFuzzBaseCase(manager, firstPart + urlFuzzStart, urlFuzzEnd);`
`126`	`126`
`127`	`127`	`} catch (IOException e) {`
`128`		`- LOGGER.error(e);`
	`128`	`+ LOGGER.error(e, e);`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`// baseCaseObj = new BaseCase(null, failcode, true, failurl, baseCase);`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ public void run() {`
`109`	`109`	`manager.setAuto(false);`
`110`	`110`	`}`
`111`	`111`	`} catch (IOException e) {`
`112`		`- LOGGER.error(e);`
	`112`	`+ LOGGER.error(e, e);`
`113`	`113`	`}`
`114`	`114`	`}`
`115`	`115`
`@@ -124,7 +124,7 @@ public void run() {`
`124`	`124`	`// get any extention that need to be checked`
`125`	`125`	`extToCheck = tempDirToCheck.getExts();`
`126`	`126`	`} catch (InterruptedException e) {`
`127`		`- LOGGER.debug(e);`
	`127`	`+ LOGGER.debug(e, e);`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`started = currentDir;`
`@@ -142,7 +142,7 @@ public void run() {`
`142`	`142`	`GenBaseCase.genBaseCase(manager, firstPart + currentDir, true, null);`
`143`	`143`
`144`	`144`	`} catch (IOException e) {`
`145`		`- LOGGER.error(e);`
	`145`	`+ LOGGER.error(e, e);`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`// baseCaseObj = new BaseCase(null, failcode, true, failurl, baseCase);`
`@@ -178,7 +178,7 @@ public void run() {`
`178`	`178`	`manager, firstPart + currentDir, false, fileExtention);`
`179`	`179`
`180`	`180`	`} catch (IOException e) {`
`181`		`- LOGGER.error(e);`
	`181`	`+ LOGGER.error(e, e);`
`182`	`182`	`}`
`183`	`183`
`184`	`184`	`// call function to generate the brute force`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ public void run() {`
`106`	`106`	`} catch (FileNotFoundException ex) {`
`107`	`107`	`LOGGER.error("File '{}' not found!", inputFile, ex);`
`108`	`108`	`} catch (IOException ex) {`
`109`		`- LOGGER.error(ex);`
	`109`	`+ LOGGER.error(ex, ex);`
`110`	`110`	`}`
`111`	`111`	`// -------------------------------------------------`
`112`	`112`
`@@ -133,7 +133,7 @@ public void run() {`
`133`	`133`	`manager.setAuto(false);`
`134`	`134`	`}`
`135`	`135`	`} catch (IOException e) {`
`136`		`- LOGGER.error(e);`
	`136`	`+ LOGGER.error(e, e);`
`137`	`137`	`}`
`138`	`138`	`}`
`139`	`139`
`@@ -178,7 +178,7 @@ public void run() {`
`178`	`178`	`baseCaseObj =`
`179`	`179`	`GenBaseCase.genBaseCase(manager, firstPart + currentDir, true, null);`
`180`	`180`	`} catch (IOException e) {`
`181`		`- LOGGER.error(e);`
	`181`	`+ LOGGER.error(e, e);`
`182`	`182`	`}`
`183`	`183`
`184`	`184`	`// end of dir fail case`
`@@ -278,7 +278,7 @@ public void run() {`
`278`	`278`	`} catch (FileNotFoundException e) {`
`279`	`279`	`LOGGER.error("File '{}' not found!", inputFile, e);`
`280`	`280`	`} catch (IOException e) {`
`281`		`- LOGGER.error(e);`
	`281`	`+ LOGGER.error(e, e);`
`282`	`282`	`}`
`283`	`283`	`}`
`284`	`284`
`@@ -308,7 +308,7 @@ public void run() {`
`308`	`308`	`GenBaseCase.genBaseCase(`
`309`	`309`	`manager, firstPart + currentDir, false, fileExtention);`
`310`	`310`	`} catch (IOException e) {`
`311`		`- LOGGER.error(e);`
	`311`	`+ LOGGER.error(e, e);`
`312`	`312`	`}`
`313`	`313`
`314`	`314`	`// if the manager has sent the stop command then exit`
`@@ -380,7 +380,7 @@ public void run() {`
`380`	`380`	`} catch (FileNotFoundException e) {`
`381`	`381`	`LOGGER.error("File '{}' not found!", inputFile, e);`
`382`	`382`	`} catch (IOException e) {`
`383`		`- LOGGER.error(e);`
	`383`	`+ LOGGER.error(e, e);`
`384`	`384`	`}`
`385`	`385`	`}`
`386`	`386`	`} // end of file ext loop`
Original file line number	Diff line number	Diff line change
`@@ -676,7 +676,7 @@ protected void bruteForceDirectoryAndChildren(SiteNode node) {`
`676`	`676`	`.getPath();`
`677`	`677`	`startScan(dir, true);`
`678`	`678`	`} catch (Exception e) {`
`679`		`- LOGGER.error(e);`
	`679`	`+ LOGGER.error(e, e);`
`680`	`680`	`}`
`681`	`681`	`}`
`682`	`682`	`}`
Original file line number	Diff line number	Diff line change
`@@ -906,7 +906,7 @@ private void notifyMessage(HttpMessage httpMessage, int historyType, ResourceSta`
`906`	`906`	`messagesTableModel.addHistoryReference(historyRef, state);`
`907`	`907`	`});`
`908`	`908`	`} catch (HttpMalformedHeaderException \| DatabaseException e) {`
`909`		`- LOGGER.error(e);`
	`909`	`+ LOGGER.error(e, e);`
`910`	`910`	`}`
`911`	`911`	`}`
`912`	`912`	`}`