fix: correctly pass modelsData to newConversation, also prevent navigation in this case (danny-avila#1162)

Author: danny-avila

client/src/hooks/useConversation.ts

@@ -51,7 +51,7 @@ const useConversation = () => {
         setSubmission({} as TSubmission);
         resetLatestMessage();
 
-        if (conversation.conversationId === 'new') {
+        if (conversation.conversationId === 'new' && !modelsData) {
           navigate('/chat/new');
         }
       },

client/src/routes/Root.tsx

@@ -38,7 +38,8 @@ export default function Root() {
   useEffect(() => {
     if (modelsQuery.data) {
       setModelsConfig(modelsQuery.data);
-      newConversation(modelsQuery.data);
+      // Note: passing modelsQuery.data prevents navigation
+      newConversation({}, undefined, modelsQuery.data);
     } else if (modelsQuery.isError) {
       console.error('Failed to get models', modelsQuery.error);
     }