35: fix duplicated code in e2e tests

Author: yusufcanb

e2e/tests/suggest.robot

@@ -16,7 +16,7 @@ ${style}        balanced
 
 *** Test Cases ***
 tlm suggest <prompt>
-    ${output}=    Run Suggestion And Verify Output    tlm suggest "list all files"
+    ${output}=    Run Hanging Command And Verify Output    tlm suggest "list all files"
     Should Contain    ${output}    ${model} is thinking...
     Should Contain    ${output}    ls
 
@@ -26,7 +26,7 @@ tlm suggest <prompt>
 
 tlm suggest --model=<model> --style=<style> <prompt>
     [Tags]    debug
-    ${output}=    Run Suggestion And Verify Output    tlm suggest --model=${model2} --style=${style} "list all files"
+    ${output}=    Run Hanging Command And Verify Output    tlm suggest --model=${model2} --style=${style} "list all files"
     Should Contain    ${output}    ${model2} is thinking...
     Should Contain    ${output}    ls
 
@@ -35,7 +35,7 @@ tlm suggest --model=<model> --style=<style> <prompt>
     Should Contain    ${output}    Cancel
 
 tlm s <prompt>
-    ${output}=    Run Suggestion And Verify Output    tlm s "list all files"
+    ${output}=    Run Hanging Command And Verify Output    tlm s "list all files"
     Should Contain    ${output}    ${model} is thinking...
     Should Contain    ${output}    ls
 

e2e/tlm_lib.py

@@ -17,71 +17,8 @@ def check_version(version: str):
         raise AssertionError(f"Version does not match regex pattern '{pattern}'")
 
 
-@keyword("Run Suggestion And Verify Output")
-def test_command_output(command) -> bool:
-    """
-    Executes a command that produces output and then waits for user input
-    (i.e. it hangs until input is provided). The function waits a few seconds
-    for the command to produce its initial output, checks that the expected
-    output is present, and asserts accordingly.
-
-    Note:
-      This function does NOT send any input to finish the process.
-      After the assertion, the process will continue to wait for input.
-
-    Parameters:
-      command (str): The shell command to run.
-      expected_output (str): A substring expected to be present in the output.
-
-    Returns:
-      proc (subprocess.Popen): The process object, still running and waiting for input.
-    """
-    # Start the process.
-    proc = subprocess.Popen(
-        command,
-        shell=True,
-        stdout=subprocess.PIPE,
-        stderr=subprocess.PIPE,
-        stdin=subprocess.PIPE,
-        text=True,  # Work with strings rather than bytes.
-        bufsize=1,  # Use line-buffering.
-    )
-
-    # A thread-safe queue to hold the output lines.
-    output_queue = queue.Queue()
-
-    def enqueue_output(out, queue_obj):
-        """
-        Reads lines from the process's stdout and places them into a queue.
-        """
-        for line in iter(out.readline, ""):
-            queue_obj.put(line)
-        out.close()
-
-    # Start a daemon thread to continuously read from proc.stdout.
-    t = threading.Thread(target=enqueue_output, args=(proc.stdout, output_queue))
-    t.daemon = True  # Ensures the thread won't block program exit.
-    t.start()
-
-    # Wait 2-3 seconds for the process to generate some output.
-    time.sleep(3)
-
-    # Drain the queue to collect the output produced so far.
-    output_lines = []
-    while True:
-        try:
-            line = output_queue.get_nowait()
-        except queue.Empty:
-            break
-        else:
-            output_lines.append(line)
-
-    partial_output = "".join(output_lines)
-    return partial_output
-
-
 @keyword("Run Hanging Command And Verify Output")
-def test_hanging_command_output(command) -> bool:
+def test_hanging_command_output(command) -> str:
     """
     Executes a command that produces output and then waits for user input
     (i.e. it hangs until input is provided). The function waits a few seconds