Properly report errors from tabs

Author: yaqwsx

kikit/panelize.py

@@ -28,7 +28,7 @@
 from kikit import substrate
 from kikit import units
 from kikit.kicadUtil import getPageDimensionsFromAst
-from kikit.substrate import Substrate, linestringToKicad, extractRings
+from kikit.substrate import Substrate, linestringToKicad, extractRings, TabError
 from kikit.defs import PAPER_DIMENSIONS, STROKE_T, Layer, EDA_TEXT_HJUSTIFY_T, EDA_TEXT_VJUSTIFY_T, PAPER_SIZES
 from kikit.common import *
 from kikit.sexpr import isElement, parseSexprF, SExpr, Atom, findNode, parseSexprListF
@@ -399,6 +399,7 @@ def buildTabs(panel: "Panel", substrate: Substrate,
                 tabs.append(t)
                 cuts.append(c)
         except TabError as e:
+            print("Caught")
             panel._renderLines(
                 [constructArrow(annotation.origin, annotation.direction, fromMm(3), fromMm(1))],
                 Layer.Margin)

kikit/substrate.py

@@ -831,6 +831,9 @@ def tab(self, origin, direction, width, partitionLine=None,
         """
         self.orient()
 
+        if self.substrates.contains(Point(origin)) and not self.substrates.boundary.contains(Point(origin)):
+            raise TabError(origin, direction, ["Tab annotation is placed inside the board. It has to be on edge or outside the board."])
+
         origin = np.array(origin)
         direction = np.around(normalize(direction), 4)
         for geom in listGeometries(self.substrates):
@@ -936,7 +939,7 @@ def millFillets(self, millRadius):
         Add fillets to inner corners which will be produced by a mill with
         given radius.
         """
-        EPS = 1 # This number is intentionally near KiCAD's resolution of 1nm to not enclose narrow slots, but to preserve radius
+        EPS = 50 # This number is intentionally near KiCAD's resolution of 1nm to not enclose narrow slots, but to preserve radius
         RES = 32
         if millRadius < EPS:
             return