Fix crash on chmod/chown of the root directory of mountpoint

vitalif · vitalif · commit 848574f1b8ab · 2023-03-02T13:48:44.000+03:00
diff --git a/internal/goofys.go b/internal/goofys.go
@@ -1622,6 +1622,11 @@ func (fs *Goofys) SetInodeAttributes(
 		return syscall.ESTALE
 	}
 
+	if inode.Parent == nil {
+		// chmod/chown on the root directory of mountpoint is not supported
+		return syscall.ENOTSUP
+	}
+
 	if op.Size != nil || op.Mode != nil || op.Mtime != nil || op.Uid != nil || op.Gid != nil {
 		inode.mu.Lock()
 	}

Original file line number	Diff line number	Diff line change
`@@ -1622,6 +1622,11 @@ func (fs *Goofys) SetInodeAttributes(`
`1622`	`1622`	`return syscall.ESTALE`
`1623`	`1623`	`}`
`1624`	`1624`
	`1625`	`+ if inode.Parent == nil {`
	`1626`	`+ // chmod/chown on the root directory of mountpoint is not supported`
	`1627`	`+ return syscall.ENOTSUP`
	`1628`	`+ }`
	`1629`	`+`
`1625`	`1630`	`if op.Size != nil \|\| op.Mode != nil \|\| op.Mtime != nil \|\| op.Uid != nil \|\| op.Gid != nil {`
`1626`	`1631`	`inode.mu.Lock()`
`1627`	`1632`	`}`