XWIKI-19948: Bad diff information when xobject is deleted #2439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
surli
commented
Oct 3, 2023
surli
commented
- Ensure to retrieve the xclass even when the xobject has been deleted
* Ensure to retrieve the xclass even when the xobject has been deleted
tmortagne
reviewed
Oct 3, 2023
xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseObject.java
Show resolved
Hide resolved
* Ensure the BaseObject contains an XClass reference when creating it
in XWikiDocument#getObjectDiff
tmortagne
approved these changes
Oct 5, 2023
surli
added a commit
that referenced
this pull request
Oct 16, 2023
* Ensure to retrieve the xclass even when the xobject has been deleted
* Ensure the BaseObject contains an XClass reference when creating it
in XWikiDocument#getObjectDiff
(cherry picked from commit f1eaec1)
surli
added a commit
that referenced
this pull request
Oct 16, 2023
* Ensure to retrieve the xclass even when the xobject has been deleted
* Ensure the BaseObject contains an XClass reference when creating it
in XWikiDocument#getObjectDiff
(cherry picked from commit f1eaec1)
Sereza7
pushed a commit
to Sereza7/xwiki-platform
that referenced
this pull request
Oct 17, 2023
* Ensure to retrieve the xclass even when the xobject has been deleted
* Ensure the BaseObject contains an XClass reference when creating it
in XWikiDocument#getObjectDiff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.