Merge pull request #44 from bacongobbler/ignore-missing-objects

fix: IgnoreMissingProperties should ignore objects

Author: xoofx

src/Tomlyn.Tests/ModelTests/ReflectionModelTests.cs

@@ -428,7 +428,9 @@ public void TestModelWithFixedList()
         public void TestModelWithMissingProperties()
         {
             var input = @"values = ['1', '2', '3']
-some_thing_that_doesnt_exist = true";
+some_thing_that_doesnt_exist = true
+[object_that_doesnt_exist]
+required = true";
 
             StandardTests.DisplayHeader("input");
             Console.WriteLine(input);

src/Tomlyn/Model/Accessors/DictionaryDynamicAccessor.cs

@@ -107,7 +107,12 @@ public override bool TryCreateAndSetDefaultPropertyValue(SourceSpan span, object
             errorMessage = $"Unexpected error when creating object for property {name} on object type {TargetType.FullName}. Reason: {ex.Message}";
         }
 
-        Context.Diagnostics.Error(span, errorMessage);
+        // If configured to ignore missing properties on the target type,
+        // return false to indicate it is missing but don't set an error
+        if (!Context.IgnoreMissingProperties)
+        {
+            Context.Diagnostics.Error(span, errorMessage);
+        }
         return false;
     }
 

src/Tomlyn/Model/Accessors/StandardObjectDynamicAccessor.cs

@@ -197,7 +197,12 @@ public override bool TryCreateAndSetDefaultPropertyValue(SourceSpan span, object
             errorMessage = $"Unexpected error when creating object for property {name} on object type {TargetType.FullName}. Reason: {ex.Message}";
         }
 
-        Context.Diagnostics.Error(span, errorMessage);
+        // If configured to ignore missing properties on the target type,
+        // return false to indicate it is missing but don't set an error
+        if (!Context.IgnoreMissingProperties)
+        {
+            Context.Diagnostics.Error(span, errorMessage);
+        }
         return false;
     }
 }