Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Commit dfa389d

Browse files
authored
Msbuild hotfix (#946)
* fixed msbuild instructions * revert android sample csproj
1 parent 94cc662 commit dfa389d

File tree

4 files changed

+29
-10
lines changed

4 files changed

+29
-10
lines changed

Directory.Build.props

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,9 @@
33

44
<PropertyGroup>
55
<LangVersion>8.0</LangVersion>
6-
<!-- Publish the repository URL in the built .nupkg (in the NuSpec <Repository> element) -->
7-
<PublishRepositoryUrl>true</PublishRepositoryUrl>
8-
<!-- Embed source files that are not tracked by the source control manager in the PDB -->
9-
<EmbedUntrackedSources>true</EmbedUntrackedSources>
10-
<!-- Build symbol package (.snupkg) to distribute the PDB containing Source Link -->
11-
<IncludeSymbols>true</IncludeSymbols>
12-
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
13-
<DebugType>embedded</DebugType>
146
</PropertyGroup>
157

8+
169
<PropertyGroup>
1710
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)Xamarin.CommunityToolkit.ruleset</CodeAnalysisRuleSet>
1811
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>

samples/XCT.Sample.Android/Xamarin.CommunityToolkit.Sample.Android.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
</PropertyGroup>
2626
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
2727
<DebugSymbols>true</DebugSymbols>
28-
<DebugType>portable</DebugType>
28+
<DebugType>full</DebugType>
2929
<Optimize>false</Optimize>
3030
<OutputPath>bin\Debug</OutputPath>
3131
<DefineConstants>DEBUG;</DefineConstants>

src/CommunityToolkit/Xamarin.CommunityToolkit/Xamarin.CommunityToolkit.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<PackageProjectUrl>https://github.com/xamarin/XamarinCommunityToolkit</PackageProjectUrl>
3131
<Configurations>Debug;Release</Configurations>
3232
<EnableDefaultCompileItems>false</EnableDefaultCompileItems>
33+
<DebugType>portable</DebugType>
3334
</PropertyGroup>
3435
<PropertyGroup Condition=" '$(Configuration)'=='Debug' ">
3536
<!-- Manage TargetFrameworks for development (Debug Mode) -->
@@ -63,7 +64,6 @@
6364
<None Include="..\..\..\LICENSE" PackagePath="" Pack="true" />
6465
<None Include="..\..\..\assets\XamarinCommunityToolkit_128x128.png" PackagePath="icon.png" Pack="true" />
6566
<PackageReference Include="Xamarin.Forms" Version="5.0.0.1874" />
66-
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All"/>
6767
</ItemGroup>
6868
<ItemGroup Condition=" $(TargetFramework.StartsWith('netstandard')) ">
6969
<Compile Include="**/*.netstandard.cs" />

src/Directory.Build.props

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
3+
<PropertyGroup Condition=" '$(Configuration)'=='Release' And '$(OS)' == 'Windows_NT' ">
4+
<DebugType>embedded</DebugType>
5+
<!-- Publish the repository URL in the built .nupkg (in the NuSpec <Repository> element) -->
6+
<PublishRepositoryUrl>true</PublishRepositoryUrl>
7+
<!-- Embed source files that are not tracked by the source control manager in the PDB -->
8+
<EmbedUntrackedSources>true</EmbedUntrackedSources>
9+
<!-- Build symbol package (.snupkg) to distribute the PDB containing Source Link -->
10+
<IncludeSymbols>true</IncludeSymbols>
11+
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
12+
</PropertyGroup>
13+
14+
<ItemGroup Condition=" '$(Configuration)'=='Release'">
15+
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
16+
</ItemGroup>
17+
18+
<PropertyGroup Condition=" '$(Configuration)'=='DEBUG' And '$(OS)' == 'Windows_NT' ">
19+
<DebugType>full</DebugType>
20+
<DebugSymbols>true</DebugSymbols>
21+
</PropertyGroup>
22+
23+
<Import Project="../Directory.Build.props" />
24+
25+
26+
</Project>

0 commit comments

Comments
 (0)