Skip to content

Commit d30a1a1

Browse files
committed
Use require_relative in the RSpec Sidekiq codebase
If there are many searches in the `$LOAD_PATH` in the user environment, require will perform unnecessary searches that are not needed. In contrast, `require_relative` is efficient because it uses a relative path.
1 parent ae5c948 commit d30a1a1

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

lib/rspec-sidekiq.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
require 'sidekiq'
66
require 'sidekiq/testing'
77

8-
require 'rspec/sidekiq/batch'
9-
require 'rspec/sidekiq/configuration'
10-
require 'rspec/sidekiq/helpers'
11-
require 'rspec/sidekiq/matchers'
12-
require 'rspec/sidekiq/sidekiq'
8+
require_relative 'rspec/sidekiq/batch'
9+
require_relative 'rspec/sidekiq/configuration'
10+
require_relative 'rspec/sidekiq/helpers'
11+
require_relative 'rspec/sidekiq/matchers'
12+
require_relative 'rspec/sidekiq/sidekiq'

lib/rspec/sidekiq/helpers.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# frozen_string_literal: true
22

33
require 'rspec/core'
4-
require 'rspec/sidekiq/helpers/within_sidekiq_retries_exhausted_block'
4+
require_relative 'helpers/within_sidekiq_retries_exhausted_block'

lib/rspec/sidekiq/matchers.rb

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
require "rspec/mocks/argument_list_matcher"
66
require "rspec/mocks/argument_matchers"
77

8-
require "rspec/sidekiq/matchers/base"
9-
require "rspec/sidekiq/matchers/be_delayed"
10-
require "rspec/sidekiq/matchers/be_expired_in"
11-
require "rspec/sidekiq/matchers/be_processed_in"
12-
require "rspec/sidekiq/matchers/be_retryable"
13-
require "rspec/sidekiq/matchers/be_unique"
14-
require "rspec/sidekiq/matchers/have_enqueued_sidekiq_job"
15-
require "rspec/sidekiq/matchers/save_backtrace"
16-
require "rspec/sidekiq/matchers/enqueue_sidekiq_job"
8+
require_relative "matchers/base"
9+
require_relative "matchers/be_delayed"
10+
require_relative "matchers/be_expired_in"
11+
require_relative "matchers/be_processed_in"
12+
require_relative "matchers/be_retryable"
13+
require_relative "matchers/be_unique"
14+
require_relative "matchers/have_enqueued_sidekiq_job"
15+
require_relative "matchers/save_backtrace"
16+
require_relative "matchers/enqueue_sidekiq_job"
1717

1818
RSpec.configure do |config|
1919
config.include RSpec::Sidekiq::Matchers

rspec-sidekiq.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
require File.expand_path("../lib/rspec/sidekiq/version", __FILE__)
3+
require_relative "lib/rspec/sidekiq/version"
44

55
Gem::Specification.new do |s|
66
s.name = "rspec-sidekiq"

0 commit comments

Comments
 (0)