Skip to content

Commit f5e9b3d

Browse files
authored
Small improvements to mobile interface (#2202)
1. pipeline step list: do not have a separate scroll container on step list 2. merge title bars on logs (probably regression of #2140)
1 parent cbb1c46 commit f5e9b3d

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

web/src/components/repo/pipeline/PipelineLog.vue

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
11
<template>
22
<div v-if="pipeline" class="flex flex-col pt-10 md:pt-0">
3-
<div
4-
class="fixed top-0 left-0 w-full md:hidden flex px-4 py-2 bg-wp-background-100 dark:bg-wp-background-200 text-wp-text-100"
5-
@click="$emit('update:step-id', null)"
6-
>
7-
<span>{{ step?.name }}</span>
8-
<Icon name="close" class="ml-auto" />
9-
</div>
10-
113
<div
124
class="flex flex-grow flex-col code-box shadow !p-0 !rounded-none md:m-2 md:mt-0 !md:rounded-md overflow-hidden"
135
@mouseover="showActions = true"
146
@mouseleave="showActions = false"
157
>
16-
<div class="flex flex-row items-center w-full bg-wp-code-100 px-4 py-2">
17-
<span class="text-base font-bold text-wp-code-text-alt-100">{{ $t('repo.pipeline.log_title') }}</span>
8+
<div class="<md:fixed <md:top-0 <md:left-0 flex flex-row items-center w-full bg-wp-code-100 px-4 py-2">
9+
<span class="text-base font-bold text-wp-code-text-alt-100">
10+
<span class="<md:hidden">{{ $t('repo.pipeline.log_title') }}</span>
11+
<span class="md:hidden">{{ step?.name }}</span>
12+
</span>
13+
1814
<div class="flex flex-row items-center ml-auto gap-x-2">
1915
<IconButton
2016
v-if="step?.end_time !== undefined"
@@ -33,6 +29,11 @@
3329
:icon="autoScroll ? 'auto-scroll' : 'auto-scroll-off'"
3430
@click="autoScroll = !autoScroll"
3531
/>
32+
<IconButton
33+
class="!hover:bg-white !hover:bg-opacity-10 !md:hidden"
34+
icon="close"
35+
@click="$emit('update:step-id', null)"
36+
/>
3637
</div>
3738
</div>
3839

@@ -105,7 +106,6 @@ import { computed, inject, nextTick, onMounted, Ref, ref, toRef, watch } from 'v
105106
import { useI18n } from 'vue-i18n';
106107
import { useRoute } from 'vue-router';
107108
108-
import Icon from '~/components/atomic/Icon.vue';
109109
import IconButton from '~/components/atomic/IconButton.vue';
110110
import PipelineStatusIcon from '~/components/repo/pipeline/PipelineStatusIcon.vue';
111111
import useApiClient from '~/compositions/useApiClient';

web/src/components/repo/pipeline/PipelineStepList.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
</div>
4949

5050
<div class="flex-grow min-h-0 w-full relative">
51-
<div class="absolute top-0 left-0 right-0 h-full flex flex-col overflow-y-scroll gap-y-2">
51+
<div class="absolute top-0 left-0 right-0 h-full flex flex-col md:overflow-y-scroll gap-y-2">
5252
<div
5353
v-for="workflow in pipeline.workflows"
5454
:key="workflow.id"

0 commit comments

Comments
 (0)