Active start date in tile #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hmmm... That's technically okay, I have nothing against it, but I think you can get this info already from the data you have. If view is month, activeStartDate is the beginning of the month the date is in, and so on. |
Contributor
Author
|
Well it differs for the adjacent months so the date of the Tile itself is not reliable to get the activeStartDate. |
Owner
|
Aaaah! You are correct. :D I missed the moment when this project got too complicated for me to remember all behaviors :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a special need for activeStartDate being available in the tileDisabled function, I believe it could be useful for other people, so here is the PR