Skip to content

Commit 6b92b3d

Browse files
chore(astro): todos cleanup (#14405)
1 parent b249684 commit 6b92b3d

File tree

4 files changed

+0
-7
lines changed

4 files changed

+0
-7
lines changed

packages/astro/src/assets/fonts/orchestrate.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ export async function orchestrate({
7272
fontMetricsResolver: FontMetricsResolver;
7373
fontTypeExtractor: FontTypeExtractor;
7474
fontFileReader: FontFileReader;
75-
// TODO: follow this implementation: https://github.com/withastro/astro/pull/13756/commits/e30ac2b7082a3eed36225da6e88449890cbcbe6b
7675
logger: Logger;
7776
createUrlProxy: (params: CreateUrlProxyParams) => UrlProxy;
7877
defaults: Defaults;

packages/astro/src/core/compile/compile.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,6 @@ export async function compile({
4747
normalizedFilename: normalizeFilename(filename, astroConfig.root),
4848
sourcemap: 'both',
4949
internalURL: 'astro/compiler-runtime',
50-
// TODO: this is no longer necessary for `Astro.site`
51-
// but it somehow allows working around caching issues in content collections for some tests
52-
astroGlobalArgs: JSON.stringify(astroConfig.site),
5350
scopedStyleStrategy: astroConfig.scopedStyleStrategy,
5451
resultScopedSlot: true,
5552
transitionsAnimationURL: 'astro/components/viewtransitions.css',

packages/astro/src/core/dev/container.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ export async function createContainer({
134134
handle(req, res) {
135135
viteServer.middlewares.handle(req, res, Function.prototype);
136136
},
137-
// TODO deprecate and remove
138137
close() {
139138
return closeContainer(container);
140139
},

packages/astro/src/runtime/server/astro-global.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ Use import.meta.glob instead: https://vitejs.dev/guide/features.html#glob-import
3434
// inside of getStaticPaths. See the `astroGlobalArgs` option for parameter type.
3535
export function createAstro(site: string | undefined): AstroGlobalPartial {
3636
return {
37-
// TODO: this is no longer necessary for `Astro.site`
38-
// but it somehow allows working around caching issues in content collections for some tests
3937
site: site ? new URL(site) : undefined,
4038
generator: `Astro v${ASTRO_VERSION}`,
4139
glob: createAstroGlobFn(),

0 commit comments

Comments
 (0)