runfix(core): Use core to decrypt federated messages (#12082)

Author: Thomas Belin

src/script/conversation/MessageRepository.ts

@@ -893,7 +893,6 @@ export class MessageRepository {
     try {
       // We delete the stored session so that it can be recreated later on
       const session_id = await this.cryptography_repository.deleteSession(userId, client_id);
-      this.core.service!.cryptography.cryptobox.session_delete(session_id);
       if (session_id) {
         this.logger.info(`Deleted session with client '${client_id}' of user '${userId.id}'.`);
       } else {

src/script/cryptography/CryptographyRepository.ts

@@ -231,6 +231,7 @@ export class CryptographyRepository {
 
   deleteSession(userId: QualifiedId, clientId: string): Promise<string> {
     const sessionId = constructClientPrimaryKey(userId, clientId);
+    this.core.service!.cryptography.cryptobox.session_delete(sessionId);
     return this.cryptobox.session_delete(sessionId);
   }
 
@@ -460,7 +461,9 @@ export class CryptographyRepository {
     const cipherText = cipherTextArray.buffer;
     const sessionId = constructClientPrimaryKey(userId, eventData.sender);
 
-    const plaintext = await this.cryptobox.decrypt(sessionId, cipherText);
+    const plaintext = isFederatedEnv
+      ? await this.core.service.cryptography.cryptobox.decrypt(sessionId, cipherText)
+      : await this.cryptobox.decrypt(sessionId, cipherText);
     return GenericMessage.decode(plaintext);
   }