-
Notifications
You must be signed in to change notification settings - Fork 334
Run containers as non-root #3352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@flokli nginz is failing to start: |
Contributor
Author
|
Seems the |
b846c04 to
5503f86
Compare
nginx does not want to see the `user` directive at all if it's already running as the desired user, so drop it from the config, as well as the corresponding helm chart values. Also drop the custom fakeNss, instead run nginx as 'nobody' user directly.
5503f86 to
870f408
Compare
jschaul
approved these changes
Jun 15, 2023
2 tasks
flokli
added a commit
that referenced
this pull request
Jun 15, 2023
This was missed to stage during #3352.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containers now run as non-root, to improve compatibility with default PodSecurityPolicies in more recent versions of Kubernetes.
This is part of WPB-1234
Checklist
changelog.d