Fix (some) HLint issues in wire-api #2065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersven
force-pushed
the
sventennie/hlint-wire-api
branch
from
a5f7c14 to
4dac022
Compare
fisx
reviewed
Jan 25, 2022
Contributor
There was a problem hiding this comment.
oops? why did you turn this on if it obviously compiled before?
Contributor
There was a problem hiding this comment.
ah, probably some overlap with RecordWildCards?
Contributor
Author
There was a problem hiding this comment.
Indeed, DisambiguateRecordFields is implied by RecordWildCards, but DisambiguateRecordFields is sufficient here.
Probably, this doesn't buy us much, but reducing HLint warnings helps to make the more important ones easier to spot...
fisx
approved these changes
Jan 25, 2022
Contributor
There was a problem hiding this comment.
ah, probably some overlap with RecordWildCards?
Contributor
There was a problem hiding this comment.
@battermann and this is why you should not mix hlint changes and feature work in the same PR! :) (see #2035)
There are a lot left, but these ones should be safe to not change the application's behavior.
supersven
force-pushed
the
sventennie/hlint-wire-api
branch
from
4dac022 to
1a99018
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing these issues has two benefits:
Checklist
changelog.d.