Improvements to cabal make targets (#1979)

* Improvements to cabal make targets

 - Speed up installation by using parallel xargs
 - Allow `package=all` to act on all packages

Author: pcapriotti

Makefile

@@ -19,6 +19,7 @@ BUILDAH_PUSH          ?= 0
 KIND_CLUSTER_NAME     := wire-server
 BUILDAH_KIND_LOAD     ?= 1
 
+package ?= all
 EXE_SCHEMA := ./dist/$(package)-schema
 
 # This ensures that focused unit tests written in hspec fail. This is supposed
@@ -44,7 +45,7 @@ install: init
 ifeq ($(WIRE_BUILD_WITH_CABAL), 1)
 	cabal build all
 	./hack/bin/cabal-run-all-tests.sh
-	./hack/bin/cabal-install-all-artefacts.sh
+	./hack/bin/cabal-install-artefacts.sh all
 else
 	stack install --pedantic --test --bench --no-run-benchmarks --local-bin-path=dist
 endif
@@ -71,11 +72,7 @@ endif
 # Usage: make ci package=brig test=1
 .PHONY: ci
 ci: c
-ifeq ("$(pattern)", "")
-	make -C services/$(package) i
-else
-	make -C services/$(package) i-$(pattern)
-endif
+	./hack/bin/cabal-run-integration.sh $(package) $(pattern)
 
 # reset db using cabal
 .PHONY: db-reset-package

changelog.d/5-internal/improve-make-c-target

@@ -0,0 +1 @@
+Improve cabal make targets: faster installation and better support for building and testing all packages

hack/bin/cabal-install-all-artefacts.sh

@@ -6,4 +6,13 @@ TOP_LEVEL="$(cd "$DIR/../.." && pwd)"
 
 DIST="$TOP_LEVEL/dist"
 
-cabal-plan list-bins "$1"':exe:*' | awk '{print $2}' | xargs -I '{}' rsync -a {} "$DIST"
+if [[ "$1" == "all" ]]; then
+  pattern='*'
+else
+  pattern="$1"
+fi
+
+cabal-plan list-bins "$pattern:exe:*" |
+  awk '{print $2}' |
+  xargs -i sh -c 'test -f {} && echo {} || true' |
+  xargs -P8 -i rsync -a {} "$DIST"

hack/bin/cabal-install-artefacts.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+TOP_LEVEL="$(cd "$DIR/../.." && pwd)"
+
+package=${1:-all}
+pattern=${2:-}
+
+opts=""
+
+if [[ "$package" != "all" ]]; then
+  opts="$opts -C services/$package"
+fi
+
+if [[ -n "$pattern" ]]; then
+  if [[ "$package" == "all" ]]; then
+    echo -e "\e[31mGlobal pattern not supported\e[0m" >&2
+    exit 1
+  fi
+  opts="$opts i-$pattern"
+else
+  opts="$opts i"
+fi
+
+exec make $opts

hack/bin/cabal-run-integration.sh

@@ -16,8 +16,6 @@ copyright:      (c) 2017 Wire Swiss GmbH
 license:        AGPL-3
 license-file:   LICENSE
 build-type:     Custom
-data-files:
-    docs/swagger.md
 
 custom-setup
   setup-depends: