Skip to content

Commit c3aaadc

Browse files
authored
Turn long summaries into descriptions (#3706)
* Turn long summaries into descriptions
1 parent d303052 commit c3aaadc

File tree

3 files changed

+19
-21
lines changed

3 files changed

+19
-21
lines changed

changelog.d/4-docs/long-summaries

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Turn long summaries in openapi documentation into descriptions

libs/wire-api/src/Wire/API/Routes/Public/Brig.hs

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -684,9 +684,8 @@ type PrekeyAPI =
684684
:<|> Named
685685
"get-multi-user-prekey-bundle-unqualified"
686686
( Summary
687-
"(deprecated) Given a map of user IDs to client IDs return a \
688-
\prekey for each one. You can't request information for more users than \
689-
\maximum conversation size."
687+
"(deprecated) Given a map of user IDs to client IDs return a prekey for each one."
688+
:> Description "You can't request information for more users than maximum conversation size."
690689
:> Until 'V2
691690
:> ZUser
692691
:> "users"
@@ -697,9 +696,8 @@ type PrekeyAPI =
697696
:<|> Named
698697
"get-multi-user-prekey-bundle-qualified@v3"
699698
( Summary
700-
"Given a map of domain to (map of user IDs to client IDs) return a \
701-
\prekey for each one. You can't request information for more users than \
702-
\maximum conversation size."
699+
"(deprecated) Given a map of user IDs to client IDs return a prekey for each one."
700+
:> Description "You can't request information for more users than maximum conversation size."
703701
:> MakesFederatedCall 'Brig "claim-multi-prekey-bundle"
704702
:> ZUser
705703
:> Until 'V4
@@ -711,9 +709,8 @@ type PrekeyAPI =
711709
:<|> Named
712710
"get-multi-user-prekey-bundle-qualified"
713711
( Summary
714-
"Given a map of domain to (map of user IDs to client IDs) return a \
715-
\prekey for each one. You can't request information for more users than \
716-
\maximum conversation size."
712+
"(deprecated) Given a map of user IDs to client IDs return a prekey for each one."
713+
:> Description "You can't request information for more users than maximum conversation size."
717714
:> MakesFederatedCall 'Brig "claim-multi-prekey-bundle"
718715
:> ZUser
719716
:> From 'V4
@@ -1570,10 +1567,10 @@ type TeamsAPI =
15701567
)
15711568
:<|> Named
15721569
"get-team-size"
1573-
( Summary
1574-
"Returns the number of team members as an integer. \
1575-
\Can be out of sync by roughly the `refresh_interval` \
1576-
\of the ES index."
1570+
( Summary "Get the number of team members as an integer"
1571+
:> Description
1572+
"Can be out of sync by roughly the `refresh_interval` \
1573+
\of the ES index."
15771574
:> CanThrow 'InvalidInvitationCode
15781575
:> ZUser
15791576
:> "teams"

libs/wire-api/src/Wire/API/Routes/Public/Galley/Conversation.hs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -723,10 +723,10 @@ type ConversationAPI =
723723
-- - MemberJoin event to members
724724
:<|> Named
725725
"join-conversation-by-code-unqualified"
726-
( Summary
727-
"Join a conversation using a reusable code.\
728-
\If the guest links team feature is disabled, this will fail with 409 GuestLinksDisabled.\
729-
\Note that this is currently inconsistent (for backwards compatibility reasons) with `POST /conversations/code-check` which responds with 404 CodeNotFound if guest links are disabled."
726+
( Summary "Join a conversation using a reusable code"
727+
:> Description
728+
"If the guest links team feature is disabled, this will fail with 409 GuestLinksDisabled.\
729+
\Note that this is currently inconsistent (for backwards compatibility reasons) with `POST /conversations/code-check` which responds with 404 CodeNotFound if guest links are disabled."
730730
:> MakesFederatedCall 'Galley "on-conversation-updated"
731731
:> CanThrow 'CodeNotFound
732732
:> CanThrow 'InvalidConversationPassword
@@ -745,10 +745,10 @@ type ConversationAPI =
745745
)
746746
:<|> Named
747747
"code-check"
748-
( Summary
749-
"Check validity of a conversation code.\
750-
\If the guest links team feature is disabled, this will fail with 404 CodeNotFound.\
751-
\Note that this is currently inconsistent (for backwards compatibility reasons) with `POST /conversations/join` which responds with 409 GuestLinksDisabled if guest links are disabled."
748+
( Summary "Check validity of a conversation code."
749+
:> Description
750+
"If the guest links team feature is disabled, this will fail with 404 CodeNotFound.\
751+
\Note that this is currently inconsistent (for backwards compatibility reasons) with `POST /conversations/join` which responds with 409 GuestLinksDisabled if guest links are disabled."
752752
:> CanThrow 'CodeNotFound
753753
:> CanThrow 'ConvNotFound
754754
:> CanThrow 'InvalidConversationPassword

0 commit comments

Comments
 (0)