Skip to content

Commit a71b2f4

Browse files
committed
Simplify rangedSchema function
1 parent d540f9b commit a71b2f4

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
`rangedSchema` does not need to be passed singletons explicitly anymore

libs/types-common/src/Data/Range.hs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -122,14 +122,12 @@ instance (Within a n m, FromJSON a) => FromJSON (Range n m a) where
122122
msg sn sm = fail (errorMsg (fromSing sn) (fromSing sm) "")
123123

124124
rangedSchema ::
125+
forall n m d v w a b.
125126
(Within a n m, HasRangedSchemaDocModifier d b) =>
126-
SNat n ->
127-
SNat m ->
128127
SchemaP d v w a b ->
129128
SchemaP d v w a (Range n m b)
130-
rangedSchema sn sm sch = Range <$> untypedRangedSchema (get sn) (get sm) sch
131-
where
132-
get = toInteger . fromSing
129+
rangedSchema sch =
130+
Range <$> untypedRangedSchema (toInteger (demote @n)) (toInteger (demote @m)) sch
133131

134132
untypedRangedSchema ::
135133
forall d v w a b.
@@ -181,7 +179,7 @@ instance S.HasSchema d S.Schema => HasRangedSchemaDocModifier d Word32 where ran
181179
instance S.HasSchema d S.Schema => HasRangedSchemaDocModifier d Word64 where rangedSchemaDocModifier _ = numRangedSchemaDocModifier
182180

183181
instance (Within a n m, ToSchema a, HasRangedSchemaDocModifier NamedSwaggerDoc a) => ToSchema (Range n m a) where
184-
schema = fromRange .= rangedSchema sing sing schema
182+
schema = fromRange .= rangedSchema schema
185183

186184
instance (Within a n m, Cql a) => Cql (Range n m a) where
187185
ctype = retag (ctype :: Tagged a ColumnType)

libs/wire-api/src/Wire/API/Conversation.hs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ import Data.Qualified (Qualified (qUnqualified), deprecatedSchema)
100100
import Data.Range (Range, fromRange, rangedSchema)
101101
import Data.Schema
102102
import qualified Data.Set as Set
103-
import Data.Singletons (sing)
104103
import Data.String.Conversions (cs)
105104
import qualified Data.Swagger as S
106105
import qualified Data.Swagger.Build.Api as Doc
@@ -366,7 +365,7 @@ instance ToSchema ListConversations where
366365
"ListConversations"
367366
(description ?~ "A request to list some of a user's conversations, including remote ones. Maximum 1000 qualified conversation IDs")
368367
$ ListConversations
369-
<$> (fromRange . lcQualifiedIds) .= field "qualified_ids" (rangedSchema sing sing (array schema))
368+
<$> (fromRange . lcQualifiedIds) .= field "qualified_ids" (rangedSchema (array schema))
370369

371370
data ConversationsResponse = ConversationsResponse
372371
{ crFound :: [Conversation],

0 commit comments

Comments
 (0)