Add (failing) tests.

Author: fisx

services/galley/test/integration/API/Teams.hs

@@ -1458,37 +1458,59 @@ testUpdateTeam = do
   g <- view tsGalley
   c <- view tsCannon
   (tid, owner, [member]) <- Util.createBindingTeamWithMembers 2
+
+  let doput :: LByteString -> Int -> TestM ()
+      doput u code =
+        put
+          ( g
+              . paths ["teams", toByteString' tid]
+              . zUser owner
+              . zConn "conn"
+              . body (RequestBodyLBS u)
+          )
+          !!! const code
+          === statusCode
+
   let bad = object ["name" .= T.replicate 100 "too large"]
-  put
-    ( g
-        . paths ["teams", toByteString' tid]
-        . zUser owner
-        . zConn "conn"
-        . json bad
-    )
-    !!! const 400
-    === statusCode
+  doput (encode bad) 400
   let u =
         newTeamUpdateData
           & nameUpdate .~ (Just $ unsafeRange "bar")
           & iconUpdate .~ fromByteString "3-1-47de4580-ae51-4650-acbb-d10c028cb0ac"
           & iconKeyUpdate .~ (Just $ unsafeRange "yyy")
           & splashScreenUpdate .~ fromByteString "3-1-e1c89a56-882e-4694-bab3-c4f57803c57a"
-  WS.bracketR2 c owner member $ \(wsOwner, wsMember) -> do
-    put
+
+  do
+    WS.bracketR2 c owner member $ \(wsOwner, wsMember) -> do
+      doput (encode u) 200
+      checkTeamUpdateEvent tid u wsOwner
+      checkTeamUpdateEvent tid u wsMember
+      WS.assertNoEvent timeout [wsOwner, wsMember]
+    t <- Util.getTeam owner tid
+    liftIO $ assertEqual "teamSplashScreen" (t ^. teamSplashScreen) (fromByteString "3-1-e1c89a56-882e-4694-bab3-c4f57803c57a")
+
+  do
+    -- setting fields to `null` is the same as omitting the them from the update json record.
+    doput "{\"name\": null, \"icon\": null, \"icon_key\": null, \"splash_screen\": null}" 200
+    t <- Util.getTeam owner tid
+    liftIO $ assertEqual "teamSplashScreen" (t ^. teamSplashScreen) (fromByteString "3-1-e1c89a56-882e-4694-bab3-c4f57803c57a")
+
+  do
+    -- setting splash screen to `"default"` won't parse as an Id.
+    doput "{\"splash_screen\": \"default\"}" 400
+
+  do
+    -- use the `delete` end-point!
+    delete
       ( g
-          . paths ["teams", toByteString' tid]
+          . paths ["teams", toByteString' tid, "splash_screen"]
           . zUser owner
           . zConn "conn"
-          . json u
       )
       !!! const 200
       === statusCode
-    checkTeamUpdateEvent tid u wsOwner
-    checkTeamUpdateEvent tid u wsMember
-    WS.assertNoEvent timeout [wsOwner, wsMember]
-  t <- Util.getTeam owner tid
-  liftIO $ assertEqual "teamSplashScreen" (t ^. teamSplashScreen) (fromByteString "3-1-e1c89a56-882e-4694-bab3-c4f57803c57a")
+    t <- Util.getTeam owner tid
+    liftIO $ assertEqual "teamSplashScreen" (t ^. teamSplashScreen) Nothing
 
 testTeamAddRemoveMemberAboveThresholdNoEvents :: HasCallStack => TestM ()
 testTeamAddRemoveMemberAboveThresholdNoEvents = do