[shared] remove extra tooltip padding. [xy-chart] fix bar offset and findclosestdatum bugs

Author: williaster

packages/shared/src/enhancer/WithTooltip.js

@@ -59,8 +59,8 @@ class WithTooltip extends React.PureComponent {
     }
 
     this.props.showTooltip({
-      tooltipLeft: coords.x + 10,
-      tooltipTop: coords.y + 10,
+      tooltipLeft: coords.x,
+      tooltipTop: coords.y,
       tooltipData: {
         event,
         datum,

packages/xy-chart/src/chart/XYChart.jsx

@@ -95,7 +95,7 @@ class XYChart extends React.PureComponent {
 
     React.Children.forEach(children, (Child) => { // Child-specific scales or adjustments here
       const name = componentName(Child);
-      if (isBarSeries(name) && xScale.type !== 'band') {
+      if (isBarSeries(name) && xScaleObject.type !== 'band') {
         const dummyBand = getScaleForAccessor({
           allData,
           minAccessor: xString,
@@ -104,7 +104,7 @@ class XYChart extends React.PureComponent {
           rangeRound: [0, innerWidth],
           paddingOuter: 1,
         });
-
+        
         const offset = dummyBand.bandwidth() / 2;
         xScale.range([offset, innerWidth - offset]);
         xScale.barWidth = dummyBand.bandwidth();

packages/xy-chart/src/series/AreaSeries.jsx

@@ -45,10 +45,10 @@ const defaultProps = {
   onMouseLeave: null,
 };
 
-const x = d => d.x;
-const getY = d => d.y;
-const getY0 = d => d.y0;
-const getY1 = d => d.y1;
+const x = d => d && d.x;
+const getY = d => d && d.y;
+const getY0 = d => d && d.y0;
+const getY1 = d => d && d.y1;
 const definedClosed = d => isDefined(getY(d));
 const definedOpen = d => isDefined(getY0(d)) && isDefined(getY1(d));
 const noEventsStyles = { pointerEvents: 'none' };

packages/xy-chart/src/series/StackedAreaSeries.jsx

@@ -42,9 +42,9 @@ const defaultProps = {
   onMouseLeave: null,
 };
 
-const x = d => d.x;
-const y0 = d => d[0];
-const y1 = d => d[1];
+const x = d => d && d.x;
+const y0 = d => d && d[0];
+const y1 = d => d && d[1];
 const defined = d => isDefined(d[0]) && isDefined(d[1]);
 const noEventsStyles = { pointerEvents: 'none' };