Revert "Delete migrations from UI (#132)" (#138)

This reverts commit 0ed25aa.

Author: ka8725

app/controllers/actual_db_schema/migrations_controller.rb

@@ -22,11 +22,6 @@ def migrate
       redirect_to migrations_path
     end
 
-    def delete
-      handle_delete(params[:id], params[:database])
-      redirect_to migrations_path
-    end
-
     private
 
     def handle_rollback(id, database)
@@ -43,13 +38,6 @@ def handle_migrate(id, database)
       flash[:alert] = e.message
     end
 
-    def handle_delete(id, database)
-      ActualDbSchema::Migration.instance.delete(id, database)
-      flash[:notice] = "Migration #{id} was successfully deleted."
-    rescue StandardError => e
-      flash[:alert] = e.message
-    end
-
     helper_method def migrations
       @migrations ||= ActualDbSchema::Migration.instance.all
       query = params[:query].to_s.strip.downcase

app/controllers/actual_db_schema/phantom_migrations_controller.rb

@@ -22,11 +22,6 @@ def rollback_all
       redirect_to phantom_migrations_path
     end
 
-    def delete
-      handle_delete(params[:id], params[:database])
-      redirect_to phantom_migrations_path
-    end
-
     private
 
     def handle_rollback(id, database)
@@ -43,13 +38,6 @@ def handle_rollback_all
       flash[:alert] = e.message
     end
 
-    def handle_delete(id, database)
-      ActualDbSchema::Migration.instance.delete(id, database)
-      flash[:notice] = "Migration #{id} was successfully deleted."
-    rescue StandardError => e
-      flash[:alert] = e.message
-    end
-
     helper_method def phantom_migrations
       @phantom_migrations ||= ActualDbSchema::Migration.instance.all_phantom
     end

app/views/actual_db_schema/migrations/index.html.erb

@@ -66,11 +66,6 @@
                                     method: :post,
                                     class: 'button migration-action',
                                     style: ('display: none;' if migration[:status] == "up" || migration[:phantom]) %>
-                      <%= button_to '✖ Delete',
-                                    delete_migration_path(id: migration[:version], database: migration[:database]),
-                                    method: :post,
-                                    data: { confirm: 'Are you sure you want to delete this migration?' },
-                                    class: 'button migration-action' %>
                     </div>
                   </td>
                 </tr>

app/views/actual_db_schema/migrations/show.html.erb

@@ -52,11 +52,6 @@
                       method: :post,
                       class: 'button migration-action',
                       style: ('display: none;' if migration[:status] == "up" || migration[:phantom]) %>
-        <%= button_to '✖ Delete',
-                      delete_migration_path(id: migration[:version], database: migration[:database]),
-                      method: :post,
-                      data: { confirm: 'Are you sure you want to delete this migration?' },
-                      class: 'button migration-action' %>
       </div>
     </div>
   </body>

app/views/actual_db_schema/phantom_migrations/index.html.erb

@@ -53,11 +53,6 @@
                                   rollback_phantom_migration_path(id: migration[:version], database: migration[:database]),
                                   method: :post,
                                   class: 'button migration-action' %>
-                    <%= button_to '✖ Delete',
-                                  delete_phantom_migration_path(id: migration[:version], database: migration[:database]),
-                                  method: :post,
-                                  data: { confirm: 'Are you sure you want to delete this migration?' },
-                                  class: 'button migration-action' %>
                   </div>
                 </td>
               </tr>

app/views/actual_db_schema/phantom_migrations/show.html.erb

@@ -46,11 +46,6 @@
                       rollback_phantom_migration_path(id: params[:id], database: params[:database]),
                       method: :post,
                       class: 'button migration-action' %>
-        <%= button_to '✖ Delete',
-                      delete_phantom_migration_path(id: params[:id], database: params[:database]),
-                      method: :post,
-                      data: { confirm: 'Are you sure you want to delete this migration?' },
-                      class: 'button migration-action' %>
       </div>
     </div>
   </body>

app/views/actual_db_schema/shared/_js.html

@@ -4,12 +4,6 @@
 
     migrationActions.forEach(button => {
       button.addEventListener('click', function(event) {
-        const confirmMessage = button.dataset.confirm;
-        if (confirmMessage && !confirm(confirmMessage)) {
-          event.preventDefault();
-          return;
-        }
-
         const originalText = button.value;
         button.value = 'Loading...';
         disableButtons();

config/routes.rb

@@ -5,13 +5,11 @@
     member do
       post :rollback
       post :migrate
-      post :delete
     end
   end
   resources :phantom_migrations, only: %i[index show] do
     member do
       post :rollback
-      post :delete
     end
     collection do
       post :rollback_all

lib/actual_db_schema/migration.rb

@@ -73,15 +73,6 @@ def migrate(version, database)
       end
     end
 
-    def delete(version, database)
-      MigrationContext.instance.each do
-        next unless ActualDbSchema.db_config[:database] == database
-
-        ActiveRecord::Base.connection.execute("DELETE FROM schema_migrations WHERE version = '#{version}'")
-        break
-      end
-    end
-
     private
 
     def build_migration_struct(status, migration)

test/controllers/actual_db_schema/migrations_controller_test.rb

@@ -26,7 +26,6 @@ def routes_setup
         get "/rails/migration/:id" => "actual_db_schema/migrations#show", as: "migration"
         post "/rails/migration/:id/rollback" => "actual_db_schema/migrations#rollback", as: "rollback_migration"
         post "/rails/migration/:id/migrate" => "actual_db_schema/migrations#migrate", as: "migrate_migration"
-        post "/rails/migration/:id/delete" => "actual_db_schema/migrations#delete", as: "delete_migration"
       end
       ActualDbSchema::MigrationsController.include(@routes.url_helpers)
     end
@@ -170,21 +169,5 @@ def down
       end
       assert_select ".flash", text: "Migration 20130906111511 was successfully rolled back."
     end
-
-    test "POST #delete removes migration record" do
-      version = "20130906111511"
-      sql = "SELECT version FROM schema_migrations WHERE version = '#{version}'"
-      ActiveRecord::Base.establish_connection(TestingState.db_config["primary"])
-
-      assert_not_nil ActiveRecord::Base.connection.select_value(sql)
-      post :delete, params: { id: version, database: @utils.primary_database }
-      assert_response :redirect
-      get :index
-      assert_select "table" do |table|
-        assert_no_match "20130906111511", table.text
-      end
-      assert_select ".flash", text: "Migration 20130906111511 was successfully deleted."
-      assert_nil ActiveRecord::Base.connection.select_value(sql)
-    end
   end
 end