Add emacs-mcx.enableDigitArgument config (#1256)

* Add emacs-mcx.enableDigitArgument config

* Update README.md and CHANGELOG.md

* Fix

Author: whitphx

CHANGELOG.md

@@ -2,6 +2,10 @@
 All notable changes to the "emacs-mcx" extension will be documented in this file.
 
 ## [Unreleased]
+
+### Add
+- `emacs-mcx.enableDigitArgument` config, #1256.
+
 ## [0.40.1] - 2022-03-20
 ### Fix
 - Release process, #1254.

README.md

@@ -102,6 +102,10 @@ Note that this config makes use of VSCode API's `type` command under the hood an
 * If you are using IME, text input may sometimes fail.
 * If another extension that also uses the `type` command is installed, an error occurs (See https://github.com/Microsoft/vscode/issues/13441).
 
+### `emacs-mcx.enableDigitArgument`
+Indicates whether `M-<digit>` (the `emacs-mcx.digitArgument` command) is enabled.
+Set `false` when `M-<digit>` conflicts with some other  necessary commands. See https://github.com/whitphx/vscode-emacs-mcx/issues/1208 for the background.
+
 ### `emacs-mcx.debug.*`
 Configurations for debugging.
 

keybinding-generator/generate-keybindings.ts

@@ -143,6 +143,7 @@ export function generateKeybindings(src: KeyBindingSource): KeyBinding[] {
   return keybindings;
 }
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function isKeyBindingSource(maybeSrc: { [key: string]: any }): maybeSrc is KeyBindingSource {
   // Check for .key
   if (typeof maybeSrc.key !== "undefined" && typeof maybeSrc.key !== "string") {
@@ -189,17 +190,25 @@ export function generateKeybindingsForPrefixArgument(): KeyBinding[] {
   for (let num = 0; num <= 9; ++num) {
     keybindings.push(
       ...generateKeybindings({
-        keys: [num.toString(), `meta+${num.toString()}`],
+        key: num.toString(),
         command: "emacs-mcx.subsequentArgumentDigit",
         when: "emacs-mcx.acceptingArgument && editorTextFocus",
         args: [num],
       })
     );
+    keybindings.push(
+      ...generateKeybindings({
+        key: `meta+${num.toString()}`,
+        command: "emacs-mcx.subsequentArgumentDigit",
+        when: "emacs-mcx.acceptingArgument && editorTextFocus && config.emacs-mcx.enableDigitArgument",
+        args: [num],
+      })
+    );
     keybindings.push(
       ...generateKeybindings({
         key: `meta+${num.toString()}`,
         command: "emacs-mcx.digitArgument",
-        when: "!emacs-mcx.acceptingArgument && editorTextFocus",
+        when: "!emacs-mcx.acceptingArgument && editorTextFocus && config.emacs-mcx.enableDigitArgument",
         args: [num],
       })
     );