Skip to content

Commit b171a26

Browse files
Revert "Fix thumbnails appearing on Android Auto even if disabled"
This reverts commit 8e5d049.
1 parent d346f5f commit b171a26

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

app/src/main/java/org/schabi/newpipe/player/mediabrowser/MediaBrowserImpl.kt

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import android.support.v4.media.MediaBrowserCompat
88
import android.support.v4.media.MediaDescriptionCompat
99
import android.util.Log
1010
import androidx.annotation.DrawableRes
11-
import androidx.core.net.toUri
1211
import androidx.media.MediaBrowserServiceCompat
1312
import androidx.media.MediaBrowserServiceCompat.Result
1413
import androidx.media.utils.MediaConstants
@@ -186,7 +185,7 @@ class MediaBrowserImpl(
186185
builder
187186
.setMediaId(createMediaIdForInfoItem(playlist is PlaylistRemoteEntity, playlist.uid))
188187
.setTitle(playlist.orderingName)
189-
.setIconUri(imageUriOrNullIfDisabled(playlist.thumbnailUrl))
188+
.setIconUri(playlist.thumbnailUrl?.let { Uri.parse(it) })
190189

191190
val extras = Bundle()
192191
extras.putString(
@@ -213,7 +212,7 @@ class MediaBrowserImpl(
213212
}
214213

215214
ImageStrategy.choosePreferredImage(item.thumbnails)?.let {
216-
builder.setIconUri(imageUriOrNullIfDisabled(it))
215+
builder.setIconUri(Uri.parse(it))
217216
}
218217

219218
return MediaBrowserCompat.MediaItem(
@@ -259,7 +258,7 @@ class MediaBrowserImpl(
259258
builder.setMediaId(createMediaIdForPlaylistIndex(false, playlistId, index))
260259
.setTitle(item.streamEntity.title)
261260
.setSubtitle(item.streamEntity.uploader)
262-
.setIconUri(imageUriOrNullIfDisabled(item.streamEntity.thumbnailUrl))
261+
.setIconUri(Uri.parse(item.streamEntity.thumbnailUrl))
263262

264263
return MediaBrowserCompat.MediaItem(
265264
builder.build(),
@@ -278,7 +277,7 @@ class MediaBrowserImpl(
278277
.setSubtitle(item.uploaderName)
279278

280279
ImageStrategy.choosePreferredImage(item.thumbnails)?.let {
281-
builder.setIconUri(imageUriOrNullIfDisabled(it))
280+
builder.setIconUri(Uri.parse(it))
282281
}
283282

284283
return MediaBrowserCompat.MediaItem(
@@ -317,7 +316,7 @@ class MediaBrowserImpl(
317316
builder.setMediaId(mediaId)
318317
.setTitle(streamHistoryEntry.streamEntity.title)
319318
.setSubtitle(streamHistoryEntry.streamEntity.uploader)
320-
.setIconUri(imageUriOrNullIfDisabled(streamHistoryEntry.streamEntity.thumbnailUrl))
319+
.setIconUri(Uri.parse(streamHistoryEntry.streamEntity.thumbnailUrl))
321320

322321
return MediaBrowserCompat.MediaItem(
323322
builder.build(),
@@ -396,13 +395,5 @@ class MediaBrowserImpl(
396395

397396
companion object {
398397
private val TAG: String = MediaBrowserImpl::class.java.getSimpleName()
399-
400-
fun imageUriOrNullIfDisabled(url: String?): Uri? {
401-
return if (ImageStrategy.shouldLoadImages()) {
402-
url?.toUri()
403-
} else {
404-
null
405-
}
406-
}
407398
}
408399
}

0 commit comments

Comments
 (0)