Skip to content

Commit bea8e73

Browse files
committed
Merge branch 'advisory-fix-1'
Fixes a panic vulnerability CVE-2023-42444 See advisory GHSA-whhr-7f2w-qqj2
2 parents 6e1d06b + 2dddb87 commit bea8e73

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

src/parser/mod.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,4 +292,10 @@ mod test {
292292
let res = parser::parse(None, " 2 22#:");
293293
assert!(res.is_err());
294294
}
295+
296+
#[test]
297+
fn advisory_1() {
298+
let res = parser::parse(None, ".;phone-context=");
299+
assert!(res.is_err(), "{res:?}");
300+
}
295301
}

src/parser/rfc3966.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ pub fn phone_number(i: &str) -> IResult<&str, Number> {
4444
params
4545
.as_ref()
4646
.and_then(|m| m.get("phone-context"))
47-
.map(|&s| if s.as_bytes()[0] == b'+' { &s[1..] } else { s })
47+
.map(|&s| s.strip_prefix('+').unwrap_or(s))
4848
})
4949
.map(|cs| cs.into()),
5050

@@ -165,4 +165,10 @@ mod test {
165165
}
166166
);
167167
}
168+
169+
#[test]
170+
fn advisory_1() {
171+
// Just make sure this does not panic.
172+
let _ = rfc3966::phone_number(".;phone-context=");
173+
}
168174
}

0 commit comments

Comments
 (0)