fix: do not crash on 'false' aliases (#1292)

Author: alexander-akait

package-lock.json

@@ -89,7 +89,7 @@
     "stylus": "^0.54.8",
     "stylus-loader": "^4.3.0",
     "url-loader": "^4.1.1",
-    "webpack": "^5.33.2"
+    "webpack": "^5.34.0"
   },
   "keywords": [
     "webpack",

package.json

@@ -40,6 +40,11 @@ const plugin = (options = {}) => {
             ...new Set([normalizedUrl, request]),
           ]);
 
+          if (!resolvedUrl) {
+            return;
+          }
+
+          // eslint-disable-next-line consistent-return
           return { url: resolvedUrl, prefix, tokens };
         };
 
@@ -49,8 +54,14 @@ const plugin = (options = {}) => {
       const results = await Promise.all(tasks);
 
       for (let index = 0; index <= results.length - 1; index++) {
-        const { url, prefix, tokens } = results[index];
-        const newUrl = prefix ? `${prefix}!${url}` : url;
+        const item = results[index];
+
+        if (!item) {
+          // eslint-disable-next-line no-continue
+          continue;
+        }
+
+        const newUrl = item.prefix ? `${item.prefix}!${item.url}` : item.url;
         const importKey = newUrl;
         let importName = imports.get(importKey);
 
@@ -68,9 +79,11 @@ const plugin = (options = {}) => {
           options.api.push({ importName, dedupe: true, index });
         }
 
-        for (const [replacementIndex, token] of Object.keys(tokens).entries()) {
+        for (const [replacementIndex, token] of Object.keys(
+          item.tokens
+        ).entries()) {
           const replacementName = `___CSS_LOADER_ICSS_IMPORT_${index}_REPLACEMENT_${replacementIndex}___`;
-          const localName = tokens[token];
+          const localName = item.tokens[token];
 
           importReplacements[token] = replacementName;
 

src/plugins/postcss-icss-parser.js

@@ -166,12 +166,10 @@ const plugin = (options = {}) => {
                 const needKeep = await options.filter(url, media);
 
                 if (!needKeep) {
-                  return null;
+                  return;
                 }
               }
 
-              atRule.remove();
-
               if (isRequestable) {
                 const request = requestify(url, options.rootContext);
 
@@ -180,9 +178,19 @@ const plugin = (options = {}) => {
                   ...new Set([request, url]),
                 ]);
 
+                if (!resolvedUrl) {
+                  return;
+                }
+
+                atRule.remove();
+
+                // eslint-disable-next-line consistent-return
                 return { url: resolvedUrl, media, prefix, isRequestable };
               }
 
+              atRule.remove();
+
+              // eslint-disable-next-line consistent-return
               return { url, media, prefix, isRequestable };
             })
           );

src/plugins/postcss-import-parser.js

@@ -292,7 +292,7 @@ const plugin = (options = {}) => {
                 const needKeep = await options.filter(url);
 
                 if (!needKeep) {
-                  return null;
+                  return;
                 }
               }
 
@@ -309,19 +309,26 @@ const plugin = (options = {}) => {
                 ...new Set([request, url]),
               ]);
 
+              if (!resolvedUrl) {
+                return;
+              }
+
+              // eslint-disable-next-line consistent-return
               return { ...parsedDeclaration, url: resolvedUrl, hash };
             })
           );
 
-          const results = await Promise.all(resolvedDeclarations);
-
           const urlToNameMap = new Map();
           const urlToReplacementMap = new Map();
 
           let hasUrlImportHelper = false;
 
-          for (let index = 0; index <= results.length - 1; index++) {
-            const item = results[index];
+          for (
+            let index = 0;
+            index <= resolvedDeclarations.length - 1;
+            index++
+          ) {
+            const item = resolvedDeclarations[index];
 
             if (!item) {
               // eslint-disable-next-line no-continue

src/plugins/postcss-url-parser.js

@@ -1865,6 +1865,10 @@ Warning
 ]
 `;
 
+exports[`"import" option should work with 'false' aliases: errors 1`] = `Array []`;
+
+exports[`"import" option should work with 'false' aliases: warnings 1`] = `Array []`;
+
 exports[`"import" option should work with a value equal to "false": errors 1`] = `Array []`;
 
 exports[`"import" option should work with a value equal to "false": module 1`] = `

test/__snapshots__/import-option.test.js.snap

@@ -4239,6 +4239,10 @@ Object {
 
 exports[`"modules" option should work with "exportOnlyLocals" and "namedExport" option: warnings 1`] = `Array []`;
 
+exports[`"modules" option should work with "false" alises: errors 1`] = `Array []`;
+
+exports[`"modules" option should work with "false" alises: warnings 1`] = `Array []`;
+
 exports[`"modules" option should work with "url" and "namedExport": errors 1`] = `Array []`;
 
 exports[`"modules" option should work with "url" and "namedExport": module 1`] = `

test/__snapshots__/modules-option.test.js.snap

@@ -655,6 +655,10 @@ Warning
 ]
 `;
 
+exports[`"url" option should work with 'false' aliases: errors 1`] = `Array []`;
+
+exports[`"url" option should work with 'false' aliases: warnings 1`] = `Array []`;
+
 exports[`"url" option should work with a value equal to "Function": errors 1`] = `Array []`;
 
 exports[`"url" option should work with a value equal to "Function": module 1`] = `

test/__snapshots__/url-option.test.js.snap

@@ -0,0 +1,5 @@
+@import "/style.css";
+
+.class {
+    color: red;
+}

test/fixtures/import/false-alias.css

@@ -0,0 +1,5 @@
+import css from './false-alias.css';
+
+__export__ = css;
+
+export default css;