Fixes form split #256
Merged
Fixes form split #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlinaGoaga
added a commit
that referenced
this pull request
Nov 5, 2021
* Add new /v1/profiles endpoint * Implement options pattern to reduce number of arguments in RunInProcessGateway * Add charts package * Add chart tests * Wire in profile helm repository * WG196 Create profiles context and prelim section in form and nav * WG196 Select profiles dropdown WIP * WG196 Select profiles dropdown WIP2 * Return profiles response * Comment out some dependencies to stop continuous loop * WG196 Yaml preview - WIP * WG196 Yaml preview - WIP2 * WG196 Preview dialog - updated * WG196 Update yaml content - WIP * WG196 Get/update yaml content for profiles * WG196 Get/update yaml content for profiles - updated * WG196 Update add cluster payload * Fix bug on refresh create form * fixes request param * rm foot.github * where that typeinfo at * wip * WG196 Include defaults when profiles are selected * WG196 Updated profiles doesnt update properly - WIP * WG196 Updated profiles updates correctly following changes in profile selection * Refactor - 1 * Refactor 2 - make select dropdown reusable * Solve conflicts with main - updated * Add error catching when getting profile yamls * Fix bug in multi select dropdown * Extract template fields from form - WIP * Extract template fields from form - WIP2 * Extract template fields from form * Extract credetials from form * Extract credetials from form - 2 * Remove abort controller from profiles * Extract gitops from form * Extract gitops from form - 2 * Extract preview from form * Extract preview from form - 2 * Fixes form split (#256) * Solve bug where PR Preview doesnt get reset when the cluster is added * Solve bug where form data doesnt update on change - WIP * Solve bug where form data doesnt update on change * Solve bug where form data doesnt update on change - updated * Solve bug where form data doesnt update on change - updated 2 * Update tests Co-authored-by: Yiannis <[email protected]> Co-authored-by: Simon Howe <[email protected]>
AlinaGoaga
added a commit
that referenced
this pull request
Dec 2, 2021
#353) * Add new /v1/profiles endpoint * Implement options pattern to reduce number of arguments in RunInProcessGateway * Add charts package * Add chart tests * Wire in profile helm repository * WG196 Create profiles context and prelim section in form and nav * WG196 Select profiles dropdown WIP * WG196 Select profiles dropdown WIP2 * Return profiles response * Comment out some dependencies to stop continuous loop * WG196 Yaml preview - WIP * WG196 Yaml preview - WIP2 * WG196 Preview dialog - updated * WG196 Update yaml content - WIP * WG196 Get/update yaml content for profiles * WG196 Get/update yaml content for profiles - updated * WG196 Update add cluster payload * Fix bug on refresh create form * fixes request param * rm foot.github * where that typeinfo at * wip * WG196 Include defaults when profiles are selected * WG196 Updated profiles doesnt update properly - WIP * WG196 Updated profiles updates correctly following changes in profile selection * Refactor - 1 * Refactor 2 - make select dropdown reusable * Solve conflicts with main - updated * Add error catching when getting profile yamls * Fix bug in multi select dropdown * Extract template fields from form - WIP * Extract template fields from form - WIP2 * Extract template fields from form * Extract credetials from form * Extract credetials from form - 2 * Remove abort controller from profiles * Extract gitops from form * Extract gitops from form - 2 * Extract preview from form * Extract preview from form - 2 * Fixes form split (#256) * Solve bug where PR Preview doesnt get reset when the cluster is added * Solve bug where form data doesnt update on change - WIP * Solve bug where form data doesnt update on change * Solve bug where form data doesnt update on change - updated * Solve bug where form data doesnt update on change - updated 2 * WG196 Get profile annos from template response * WG196 Move building updated profiles to context - WIP * WG196 Move building updated profiles to context * WG196 Required / Not Required profiles WIP * WG196 Required / Not Required profiles WIP2 * WG196 Required / Not Required profiles WIP3 * WG196 Required profiles are preselected and can't be unselected * Update enabled/disabled styling in dropdown * Update enabled/disabled styling in dropdown - 2 * Explore options * Update enabled/disabled styling in dropdown - 3 * cleanup logs * Explore options - 2 * Fix optional profiles on refresh * no dev/charts * Add visible attribute to properties * WG274 Update profile context to multiple versions and Versions Drodown - WIP * WG274 Attach idenitifier to response payload for yaml values retrieval * WG274 Update profile list to work with the new enrichedProfiles structure - WIP * WG274 Extract ProfileListItem * WG274 Extract ProfileListItem - updated * WG274 Extract ProfileListItem - updated2 * WG274 Refactor Profile Provider - WIP * WG274 Refactor Profile Provider - WIP2 * WG274 Fix encoding of profiles after selection * WG274 Set version/value to first elem of array in profile list * WG274 Update profile list to be sent with the required profiles * WG274 Update profile list styling * WG274 Update profile list styling - updated * Small cleanup * Default to v1/profiles yaml values if required profile yaml is empty * WG273 Register visited fields as we build form - WIP * WG273 Add visible property to Form Section individual ReactNode * WG273 Update step to show count of prop * WG273 Show all relevant children on child[0] info * WG273 Update form styling * WG273 Update form styling - updated * WG273 Hide number of occurences button for second+ children * Fix test * Small style update * Prevent submit on show populated fields * Fix some more tests * WG273 Update toggle show-hide form fields * Target children which aren't the first in their list * WG273 Switch to show fields when user is typing * WG273 Update style of disabled children * Refactor children visibility * Implement feedback - exclude sections where no user input is necessary from the form * Update step title to show the no of hidden fields * Exp with some useMemos * Move checking visibility to parent * Form rerenders on uiSchema update * Move doGrouping back to Grouped Schema * Disable children that arent firstOfAKind * Disable children that arent firstOfAKind - updated * Fixes ui-int selectors * Revert some test modification * Revert headers to their former glory * Switch tests back to checking 1.Cluster * Fixes up filling in forms * Update acceptance tests Co-authored-by: Yiannis <[email protected]> Co-authored-by: Simon Howe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.