Support for specifying path for profiles in templates #2225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranatrk
force-pushed
the
2107-profile-path-support
branch
3 times, most recently
from
b2b6651 to
91c9a6d
Compare
foot
reviewed
Jan 19, 2023
foot
reviewed
Jan 19, 2023
cmd/clusters-service/pkg/templates/testdata/template-with-profiles-params.yaml
Outdated
Show resolved
Hide resolved
ranatrk
force-pushed
the
2107-profile-path-support
branch
from
df2d7d7 to
b222969
Compare
…helmRepositoryTemplate path and helmReleaseTemplate paths
…seTemplateSpec Add test case for unique helm release template path in processor test
ranatrk
force-pushed
the
2107-profile-path-support
branch
from
f992388 to
d18cbdc
Compare
ranatrk
force-pushed
the
2107-profile-path-support
branch
from
6849364 to
d6ee10b
Compare
ranatrk
force-pushed
the
2107-profile-path-support
branch
from
d6ee10b to
430cd58
Compare
- Fixes small regression where required=false should allow editing
foot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2107
depends on : weaveworks/templates-controller#8
What changed?
0.1.1v0.1.2Why was this change made?
To be used to allow users to specify the path of the helm repository or each helm release
How was this change implemented?
Update charts spec of templates with HelmRepositoryTemplate path and HelmReleaseTemplate path
How did you validate the change?
manual test full scenario
unit test cases for retrieving params for helmRepositoryTemplate path, helmReleaseTemplate path
Release notes
Documentation Changes