Add Dependency Graph for Terraform objects #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
approved these changes
Jan 13, 2023
Contributor
There was a problem hiding this comment.
LGTM! 🎉 Great job, @joshri !
Adding unit tests from the DependenciesView in Core and reworking them for the Terraform Dependencies View would be great, but we can do it in a followup PR. As well as tweak arrow positioning a bit in the same followup PR. But it is working great for me in general!
This was referenced Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1988
The bulk of this code comes from @opudrovs excellent work on the dependency tab for automations in OSS - using it here required adding the
dependsOnfield to the terraform backend, and creating theTerraformObjectNodetype, which adds a couple fields to make Terraform objects compatible with the existing code (isCurrentNode,parentIds,type, andid).I also moved the styled components for the
NoRunsMessageto the Shared.ts file and reused them here.