Fixed random installation failure of ingress-ngix during setup manage… #1877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedfazal
added
exclude from release notes
foot
reviewed
Nov 14, 2022
| helm install my-mccp wkpv3/mccp --version "${CHART_VERSION}" --namespace flux-system ${helmArgs[@]} | ||
|
|
||
| # Wait for cluster to settle | ||
| kubectl wait --for=condition=Ready --timeout=300s -n flux-system --all pod |
Collaborator
There was a problem hiding this comment.
Other thing that comes to mind is to helm install --wait above which will wait for pods / services to be available,
--wait if set, will wait until all Pods, PVCs, Services, and minimum number of Pods of a Deployment, StatefulSet, or ReplicaSet are in a ready state before marking the release as successful. It will wait for as long as --timeout
https://helm.sh/docs/helm/helm_install/
Which I would assume would be in the main chart at least, maybe the subcharts too (like policy-agent), not sure exactly.
foot
approved these changes
Nov 14, 2022
| - Create a new clean kind cluster. | ||
|
|
||
| `kind create cluster --config test/utils/data/local-kind-config.yaml` | ||
| `./test/utils/scripts/mgmt-cluster-setup.sh kind $(pwd) mgmt-kind` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.