Skip to content

Add create namespace checkbox to Add Application #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarataha merged 18 commits into from
Sep 28, 2022
Merged

Add create namespace checkbox to Add Application #1528

sarataha merged 18 commits into from
Sep 28, 2022

Conversation

@sarataha
Copy link
Member

@sarataha sarataha commented Sep 15, 2022 •
edited
Loading

Fixes: #1511

  • Added a 'Create Namespace' checkbox.
  • If create_namespace is true, add a namespace resource to the committed files.

@sarataha sarataha added bug Something isn't working team/pesto labels Sep 15, 2022
@sarataha sarataha force-pushed the add-create-namespace branch from 4e1190e to 2d74ad0 Compare September 15, 2022 12:33
AlinaGoaga and others added 14 commits September 22, 2022 13:05
@AlinaGoaga
Merge branch 'add-create-namespace' of github.com:weaveworks/weave-gi…
2a93535 
…tops-enterprise into add-create-namespace
@AlinaGoaga
Add create namespace checkbox in FE - WIP
0b95229
Merge branch 'main' into add-create-namespace
4465bdb
Make field name more descriptive
7c4c9f5
Add create_namespace to kustomization spec
3d1d9dc
Merge branch 'main' into add-create-namespace
1bfd8be
@AlinaGoaga
Merge branch 'main' of github.com:weaveworks/weave-gitops-enterprise …
94387ae 
…into add-create-namespace
@AlinaGoaga
Add checkbox - fix location of data
d1eed7b
Add namespace resource to the committed files
b2b2f4e
@AlinaGoaga
Checkbox styling
8bc27a2
@AlinaGoaga
Merge branch 'add-create-namespace' of github.com:weaveworks/weave-gi…
fbd2e4b 
…tops-enterprise into add-create-namespace
@AlinaGoaga
Remove log
0691e36
@AlinaGoaga
Remove log - updated
c5bee89
Fix conflict.
55a4ba4
@sarataha sarataha marked this pull request as ready for review September 26, 2022 10:51
@sarataha sarataha requested review from ahussein3 and foot September 26, 2022 10:53
foot
foot approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

@sarataha sarataha merged commit 0da5f0a into main Sep 28, 2022
@sarataha sarataha deleted the add-create-namespace branch September 28, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@foot foot foot approved these changes

@ahussein3 ahussein3 Awaiting requested review from ahussein3

Assignees

No one assigned

Labels

bug Something isn't working team/pesto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add application to new CAPI cluster in a non-existing namespace fails/stops the flux reconciliation

4 participants

@sarataha @foot @AlinaGoaga