Disable the "Delivery" item in the navbar so we can release (#1034)

* Disable the "Delivery" item in the navbar so we can release

- This is a hack. That we can remove post-release and in the future we
  should implement a better feature-flagging system

* Move REACT_APP_DISABLE_PROGRESSIVE_DELIVERY up to only run in ci

- to cause less disruption
- if it works okay we can move to release

Author: foot

.github/workflows/build.yaml

@@ -24,6 +24,7 @@ env:
   NODE_MODULES_CACHE_NAME: cache-node-modules
   NODE_VERSION: "14"
   HELM_REPO: ${{ inputs.helmrepo }}
+  REACT_APP_DISABLE_PROGRESSIVE_DELIVERY: "true"
 
 jobs:
   helm-chart:

Makefile

@@ -57,6 +57,7 @@ ui-cra/.uptodate: ui-cra/*
 		--build-arg=version=$(WEAVE_GITOPS_VERSION) \
 		--build-arg=revision=$(GIT_REVISION) \
 		--build-arg=GITHUB_TOKEN=$(GITHUB_BUILD_TOKEN) \
+		--build-arg=REACT_APP_DISABLE_PROGRESSIVE_DELIVERY=$(REACT_APP_DISABLE_PROGRESSIVE_DELIVERY) \
 		--build-arg=now=$(TIME_NOW) \
 		--tag $(UI_SERVER) \
 		$(@D)/

ui-cra/Dockerfile

@@ -6,6 +6,7 @@ COPY --chown=node:node .npmrc /home/node
 COPY --chown=node:node yarn.lock /home/node
 COPY --chown=node:node Makefile /home/node
 
+ARG REACT_APP_DISABLE_PROGRESSIVE_DELIVERY
 ARG GITHUB_TOKEN
 RUN make node_modules
 

ui-cra/Makefile

@@ -4,7 +4,7 @@ node_modules: package.json yarn.lock
 	yarn config set network-timeout 300000 && yarn install --prod --frozen-lockfile
 
 build: node_modules $(shell find src -type f)
-	REACT_APP_VERSION="$(CALENDAR_VERSION) $(VERSION)" yarn build
+	REACT_APP_DISABLE_PROGRESSIVE_DELIVERY="$(REACT_APP_DISABLE_PROGRESSIVE_DELIVERY)" REACT_APP_VERSION="$(CALENDAR_VERSION) $(VERSION)" yarn build
 
 core-lib:
 	rm -rf node_modules/@weaveworks/weave-gitops/

ui-cra/src/components/Navigation.tsx

@@ -108,9 +108,11 @@ export const Navigation: FC = () => {
           <NavItem className={classes.subItem} to={V2Routes.Sources}>
             Sources
           </NavItem>
+          {process.env.REACT_APP_DISABLE_PROGRESSIVE_DELIVERY !== 'true' && (
             <NavItem className={classes.subItem} to="/applications/delivery">
               Delivery
             </NavItem>
+          )}
           <NavItem to={V2Routes.FluxRuntime}>Flux Runtime</NavItem>
         </Box>
         <Box className={classes.section}>