Merge pull request #624 from weaveworks/policies_date_format

chore(api): use ISO format for policy create time

Author: alichaddad

cmd/clusters-service/pkg/server/policies.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"strconv"
+	"time"
 
 	"github.com/golang/protobuf/ptypes/any"
 	policiesv1 "github.com/weaveworks/policy-agent/api/v1"
@@ -98,7 +99,7 @@ func toPolicyResponse(policyCRD policiesv1.Policy) (*capiv1_proto.Policy, error)
 			Labels:     policyLabels,
 		},
 		Parameters: policyParams,
-		CreatedAt:  policyCRD.CreationTimestamp.UTC().String(),
+		CreatedAt:  policyCRD.CreationTimestamp.Format(time.RFC3339),
 	}
 
 	return policy, nil

cmd/clusters-service/pkg/server/policies_test.go

@@ -42,7 +42,7 @@ func TestListPolicies(t *testing.T) {
 						Name:      "Missing app Label",
 						Severity:  "medium",
 						Code:      "foo",
-						CreatedAt: "0001-01-01 00:00:00 +0000 UTC",
+						CreatedAt: "0001-01-01T00:00:00Z",
 						Targets: &capiv1_proto.PolicyTargets{
 							Labels: []*capi_server.PolicyTargetLabel{
 								{
@@ -55,7 +55,7 @@ func TestListPolicies(t *testing.T) {
 						Name:      "Missing Owner Label",
 						Severity:  "high",
 						Code:      "foo",
-						CreatedAt: "0001-01-01 00:00:00 +0000 UTC",
+						CreatedAt: "0001-01-01T00:00:00Z",
 						Targets: &capiv1_proto.PolicyTargets{
 							Labels: []*capi_server.PolicyTargetLabel{
 								{
@@ -96,7 +96,7 @@ func TestListPolicies(t *testing.T) {
 								},
 							},
 						},
-						CreatedAt: "0001-01-01 00:00:00 +0000 UTC",
+						CreatedAt: "0001-01-01T00:00:00Z",
 						Parameters: []*capi_server.PolicyParam{
 							{
 								Name:  "key",
@@ -137,7 +137,7 @@ func TestListPolicies(t *testing.T) {
 								},
 							},
 						},
-						CreatedAt: "0001-01-01 00:00:00 +0000 UTC",
+						CreatedAt: "0001-01-01T00:00:00Z",
 						Parameters: []*capi_server.PolicyParam{
 							{
 								Name:  "key",
@@ -178,7 +178,7 @@ func TestListPolicies(t *testing.T) {
 								},
 							},
 						},
-						CreatedAt: "0001-01-01 00:00:00 +0000 UTC",
+						CreatedAt: "0001-01-01T00:00:00Z",
 						Parameters: []*capi_server.PolicyParam{
 							{
 								Name:  "key",
@@ -219,7 +219,7 @@ func TestListPolicies(t *testing.T) {
 								},
 							},
 						},
-						CreatedAt: "0001-01-01 00:00:00 +0000 UTC",
+						CreatedAt: "0001-01-01T00:00:00Z",
 						Parameters: []*capi_server.PolicyParam{
 							{
 								Name:  "key",
@@ -317,7 +317,7 @@ func TestGetPolicy(t *testing.T) {
 							},
 						},
 					},
-					CreatedAt: "0001-01-01 00:00:00 +0000 UTC",
+					CreatedAt: "0001-01-01T00:00:00Z",
 				},
 			},
 		},