check filesize/info before reading full contents

Author: sawka

frontend/app/aipanel/ai-utils.ts

@@ -181,11 +181,11 @@ export interface FileSizeError {
     fileType: "text" | "pdf" | "image";
 }
 
-export const validateFileSize = (file: File): FileSizeError | null => {
-    const TEXT_FILE_LIMIT = 200 * 1024; // 200KB
-    const PDF_LIMIT = 5 * 1024 * 1024; // 5MB
-    const IMAGE_LIMIT = 10 * 1024 * 1024; // 10MB
+const TEXT_FILE_LIMIT = 200 * 1024; // 200KB
+const PDF_LIMIT = 5 * 1024 * 1024; // 5MB
+const IMAGE_LIMIT = 10 * 1024 * 1024; // 10MB
 
+export const validateFileSize = (file: File): FileSizeError | null => {
     if (file.type.startsWith("image/")) {
         if (file.size > IMAGE_LIMIT) {
             return {
@@ -218,6 +218,33 @@ export const validateFileSize = (file: File): FileSizeError | null => {
     return null;
 };
 
+export const validateFileSizeFromInfo = (fileName: string, fileSize: number, mimeType: string): FileSizeError | null => {
+    let maxSize: number;
+    let fileType: "text" | "pdf" | "image";
+
+    if (mimeType.startsWith("image/")) {
+        maxSize = IMAGE_LIMIT;
+        fileType = "image";
+    } else if (mimeType === "application/pdf") {
+        maxSize = PDF_LIMIT;
+        fileType = "pdf";
+    } else {
+        maxSize = TEXT_FILE_LIMIT;
+        fileType = "text";
+    }
+
+    if (fileSize > maxSize) {
+        return {
+            fileName,
+            fileSize,
+            maxSize,
+            fileType,
+        };
+    }
+
+    return null;
+};
+
 export const formatFileSizeError = (error: FileSizeError): string => {
     const typeLabel = error.fileType === "image" ? "Image" : error.fileType === "pdf" ? "PDF" : "Text file";
     return `${typeLabel} "${error.fileName}" is too large (${formatFileSize(error.fileSize)}). Maximum size is ${formatFileSize(error.maxSize)}.`;

frontend/app/aipanel/aipanel.tsx

@@ -323,12 +323,12 @@ const AIPanelComponentInner = memo(({ className, onClose }: AIPanelProps) => {
 
     const handleDragOver = (e: React.DragEvent) => {
         const hasFiles = hasFilesDragged(e.dataTransfer);
-        
+
         // Only handle native file drags here, let react-dnd handle FILE_ITEM drags
         if (!hasFiles) {
             return;
         }
-        
+
         e.preventDefault();
         e.stopPropagation();
 
@@ -339,12 +339,12 @@ const AIPanelComponentInner = memo(({ className, onClose }: AIPanelProps) => {
 
     const handleDragEnter = (e: React.DragEvent) => {
         const hasFiles = hasFilesDragged(e.dataTransfer);
-        
+
         // Only handle native file drags here, let react-dnd handle FILE_ITEM drags
         if (!hasFiles) {
             return;
         }
-        
+
         e.preventDefault();
         e.stopPropagation();
 
@@ -353,12 +353,12 @@ const AIPanelComponentInner = memo(({ className, onClose }: AIPanelProps) => {
 
     const handleDragLeave = (e: React.DragEvent) => {
         const hasFiles = hasFilesDragged(e.dataTransfer);
-        
+
         // Only handle native file drags here, let react-dnd handle FILE_ITEM drags
         if (!hasFiles) {
             return;
         }
-        
+
         e.preventDefault();
         e.stopPropagation();
 
@@ -424,7 +424,6 @@ const AIPanelComponentInner = memo(({ className, onClose }: AIPanelProps) => {
 
     // Update drag over state for FILE_ITEM drags
     useEffect(() => {
-        console.log("FILE_ITEM drag state:", { isOver, canDrop });
         if (isOver && canDrop) {
             setIsReactDndDragOver(true);
         } else {

frontend/app/aipanel/waveai-model.tsx

@@ -16,11 +16,19 @@ import { TabRpcClient } from "@/app/store/wshrpcutil";
 import { WorkspaceLayoutModel } from "@/app/workspace/workspace-layout-model";
 import { BuilderFocusManager } from "@/builder/store/builder-focusmanager";
 import { getWebServerEndpoint } from "@/util/endpoints";
+import { base64ToArrayBuffer } from "@/util/util";
 import { ChatStatus } from "ai";
 import * as jotai from "jotai";
 import type React from "react";
-import { base64ToArrayBuffer } from "@/util/util";
-import { createDataUrl, createImagePreview, isAcceptableFile, normalizeMimeType, resizeImage, validateFileSize, formatFileSizeError } from "./ai-utils";
+import {
+    createDataUrl,
+    createImagePreview,
+    formatFileSizeError,
+    isAcceptableFile,
+    normalizeMimeType,
+    resizeImage,
+    validateFileSizeFromInfo,
+} from "./ai-utils";
 import type { AIPanelInputRef } from "./aipanelinput";
 
 export interface DroppedFile {
@@ -159,39 +167,39 @@ export class WaveAIModel {
         }
 
         try {
-            const fileData = await RpcApi.FileReadCommand(
-                TabRpcClient,
-                {
-                    info: {
-                        path: draggedFile.uri,
-                    },
-                },
-                null
-            );
+            const fileInfo = await RpcApi.FileInfoCommand(TabRpcClient, { info: { path: draggedFile.uri } }, null);
+            if (fileInfo.notfound) {
+                this.setError(`File not found: ${draggedFile.relName}`);
+                return;
+            }
+            if (fileInfo.isdir) {
+                this.setError("Cannot add directories to Wave AI. Please select a file.");
+                return;
+            }
+
+            const mimeType = fileInfo.mimetype || "application/octet-stream";
+            const fileSize = fileInfo.size || 0;
+            const sizeError = validateFileSizeFromInfo(draggedFile.relName, fileSize, mimeType);
+            if (sizeError) {
+                this.setError(formatFileSizeError(sizeError));
+                return;
+            }
 
+            const fileData = await RpcApi.FileReadCommand(TabRpcClient, { info: { path: draggedFile.uri } }, null);
             if (!fileData.data64) {
                 this.setError(`Failed to read file: ${draggedFile.relName}`);
                 return;
             }
 
             const buffer = base64ToArrayBuffer(fileData.data64);
-
-            const mimeType = fileData.info?.mimetype || "application/octet-stream";
             const file = new File([buffer], draggedFile.relName, { type: mimeType });
-
             if (!isAcceptableFile(file)) {
                 this.setError(
                     `File type not supported: ${draggedFile.relName}. Supported: images, PDFs, and text/code files.`
                 );
                 return;
             }
 
-            const sizeError = validateFileSize(file);
-            if (sizeError) {
-                this.setError(formatFileSizeError(sizeError));
-                return;
-            }
-
             await this.addFile(file);
         } catch (error) {
             console.error("Error handling FILE_ITEM drop:", error);