on windows, must close the new temp file before removing it (#1115)

Closes #1114

Author: sawka

pkg/util/utilfn/utilfn.go

@@ -863,9 +863,9 @@ func AtomicRenameCopy(dstPath string, srcPath string, perms os.FileMode) error {
 	if err != nil {
 		return err
 	}
-	defer dstFd.Close()
 	_, err = io.Copy(dstFd, srcFd)
 	if err != nil {
+		dstFd.Close()
 		return err
 	}
 	err = dstFd.Close()

pkg/wshrpc/wshremote/wshremote.go

@@ -231,10 +231,11 @@ func checkIsReadOnly(path string, fileInfo fs.FileInfo, exists bool) bool {
 			return false
 		}
 		tmpFileName := filepath.Join(dirName, "wsh-tmp-"+randHexStr)
-		_, err = os.Create(tmpFileName)
+		fd, err := os.Create(tmpFileName)
 		if err != nil {
 			return true
 		}
+		fd.Close()
 		os.Remove(tmpFileName)
 		return false
 	}