-
-
Notifications
You must be signed in to change notification settings - Fork 46
Export validate_state()+ validate_county() and add tests
#204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export validate_state()+ validate_county() and add tests
#204
Conversation
Add rlang and cli to Imports Also refactor input_to_wkt function to: - allow sfc input - warn if object contains multiple geometries after union is applied
Also expose geos_method argument internally
validate_state()+ validate_county()validate_state()+ validate_county() and add tests
|
Thanks Eli! It'll be helpful to go through this incrementally. Just let me know when it's ready for review. |
|
@walkerke I think this it is ready now! I caught a typo while testing the branch this morning so I decided to pull in the tests from my original PR and make sure I hadn't introduced any other breaking bugs. The tests should also make it easier to review any additional PRs since they will catch any major regressions. I will say thought that the tests are pretty basic so feel free to suggest changes if you have any approaches you prefer. |
|
If the tests continue to fail unpredictably with GitHub Actions, I can add |
|
I will keep an eye on it! I'll get this fully reviewed shortly. |
|
Thanks Eli! I do see that some tests are failing - I think this will be useful for monitoring performance locally, but I'm adding |
|
That sounds like a good approach! I can open a second PR that pulls the new validation functions into all of the data access functions. I'm still working my way through the changes from that old, overloaded PR and hoping that the tests will make all of the remaining changes much easier to review. |
|
sounds good! I also added you as a package contributor in DESCRIPTION, I put the email I could find on the web but go ahead and change it to a different one if you want |
This is the first in what is likely going to be a series of PRs to pull the relevant and useful feature additions from this conflicted and over-large PR #197
Changes in this PR:
validate_state()+validate_county()with the addition of various helper functionsvalidate_state()+validate_county()with newmultipleargument{rlang}and{cli}to Imports{withr}to Suggestsinput_to_wkt()function to allow sfc input objects and warn if object contains multiple geometries aftersf::st_unionis appliedRelated #136