fix: prevent setting shard info from PX if it exists (#2561)

* prevent setting px shard info

* address review

Author: weboko

packages/discovery/src/peer-exchange/peer_exchange_discovery.ts

@@ -207,18 +207,20 @@ export class PeerExchangeDiscovery
         continue;
       }
 
+      const hasPrevShardInfo = await this.hasShardInfo(peerInfo.id);
+      const metadata =
+        !hasPrevShardInfo && shardInfo
+          ? { metadata: { shardInfo: encodeRelayShard(shardInfo) } }
+          : undefined;
+
       // merge is smart enough to overwrite only changed parts
       await this.components.peerStore.merge(peerInfo.id, {
         tags: {
           [DEFAULT_PEER_EXCHANGE_TAG_NAME]: {
             value: DEFAULT_PEER_EXCHANGE_TAG_VALUE
           }
         },
-        ...(shardInfo && {
-          metadata: {
-            shardInfo: encodeRelayShard(shardInfo)
-          }
-        }),
+        ...metadata,
         ...(peerInfo.multiaddrs && {
           multiaddrs: peerInfo.multiaddrs
         })
@@ -236,6 +238,22 @@ export class PeerExchangeDiscovery
       );
     }
   }
+
+  private async hasShardInfo(peerId: PeerId): Promise<boolean> {
+    try {
+      const peer = await this.components.peerStore.get(peerId);
+
+      if (!peer) {
+        return false;
+      }
+
+      return peer.metadata.has("shardInfo");
+    } catch (err) {
+      log.warn(`Error getting shard info for ${peerId.toString()}`, err);
+    }
+
+    return false;
+  }
 }
 
 export function wakuPeerExchangeDiscovery(