Merge pull request #1547 from ArepMM/fix-plane-valid

robertosfield · web-flow · commit b1b846572c4c · 2025-07-26T08:55:50.000+01:00
Any nonzero component of the plane's normal vector is enough for valid()
diff --git a/include/vsg/maths/plane.h b/include/vsg/maths/plane.h
@@ -100,7 +100,7 @@ namespace vsg
             value[3] = in_d;
         }
 
-        bool valid() const { return n.x != numbers<value_type>::zero() && n.y != numbers<value_type>::zero() && n.z != numbers<value_type>::zero(); }
+        bool valid() const { return n.x != numbers<value_type>::zero() || n.y != numbers<value_type>::zero() || n.z != numbers<value_type>::zero(); }
 
         explicit operator bool() const noexcept { return valid(); }
 

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ namespace vsg`
`100`	`100`	`value[3] = in_d;`
`101`	`101`	`}`
`102`	`102`
`103`		`- bool valid() const { return n.x != numbers<value_type>::zero() && n.y != numbers<value_type>::zero() && n.z != numbers<value_type>::zero(); }`
	`103`	`+ bool valid() const { return n.x != numbers<value_type>::zero() \|\| n.y != numbers<value_type>::zero() \|\| n.z != numbers<value_type>::zero(); }`
`104`	`104`
`105`	`105`	`explicit operator bool() const noexcept { return valid(); }`
`106`	`106`