Replies: 4 comments
-
|
Does ruff support auto-formatting if the format does not meet the rule? |
Beta Was this translation helpful? Give feedback.
-
we can enable auto-formating with pre-commit, adding ruff as a hook of the pre-commit will apply the ruff rules. |
Beta Was this translation helpful? Give feedback.
-
Indeed, I configured this before and I can help if we decide to migrate to ruff. |
Beta Was this translation helpful? Give feedback.
-
|
Will there be a check if pre-commit is skipped by the user? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Motivation
The current imports in the
verlrepository is messy. We might need some tool to streamline and standardize import management.Draft Proposal
Given our current development pipeline that utilizes
yapffor formatting andpylintfor linting, we present two primary options:isortinto the existing pipeline for import organization.ruff, a comprehensive tool that can handle formatting, linting, and import organization simultaneously.Question(s) to Discuss
Which option would be more suitable for our needs? You could make a vote under this issue using 😄 for
isortor 🚀 forruff.Additional Notes
This RFC issue is adapted from vLLM's awesome RFC issue template. If such a template seems useful to you, we may consider adding similar templates to the
verlrepository.CC
@vermouth1992 @eric-haibin-lin @PeterSH6 @hiyouga @ETOgaosion @BearBiscuit05
Before Submitting
Beta Was this translation helpful? Give feedback.
All reactions