Skip to content

Commit 8346efb

Browse files
Merge branch 'volcengine:main' into ds_nokl
2 parents c1ca9c1 + 5c98ed1 commit 8346efb

File tree

227 files changed

+9551
-3181
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

227 files changed

+9551
-3181
lines changed

.github/CODEOWNERS

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,21 @@
22
/docs/amd_tutorial @yushengsu-thu
33
/docs/slang_multiturn @zhaochenyang20 @SwordFaith
44

5-
/recipe/dapo @tongyx361 @PeterSH6
5+
/recipe/dapo @tongyx361 @PeterSH6 @vermouth1992 @tardis-key @FightingZhen @ji-huazhong
66
/recipe/spin @zhaochenyang20
77
/recipe/sppo @zhaochenyang20
88

99
/third_party/sglang @zhaochenyang20 @SwordFaith
1010
/third_party/vllm @PeterSH6 @wuxibin89
11+
/examples/grpo_trainer @vermouth1992 @PeterSH6 @tardis-key @FightingZhen @ji-huazhong
1112
/verl/single_controller @zw0610 @wuxibin89 @hongpeng-guo
1213
/verl/trainer @eric-haibin-lin @vermouth1992 @tongyx361 @PeterSH6
1314
/verl/workers/engine @eric-haibin-lin @vermouth1992 @ZihengJiang
1415
/verl/workers/roles @eric-haibin-lin @vermouth1992 @ZihengJiang
1516
/verl/workers/engine/fsdp @eric-haibin-lin @vermouth1992 @ZihengJiang
1617
/verl/workers/rollout/vllm_rollout @wuxibin89 @PeterSH6 @chenhaiq
1718
/verl/workers/rollout/sglang_rollout @zhaochenyang20 @SwordFaith @chenhaiq
19+
/verl/models/transformers @vermouth1992 @PeterSH6 @tardis-key @FightingZhen @ji-huazhong
1820

1921
/tests/single_controller @zw0610 @wuxibin89
2022
/tests/trainer @eric-haibin-lin @vermouth1992 @tongyx361 @PeterSH6
Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,65 @@
1+
# modified from https://github.com/huggingface/transformers/blob/main/.github/ISSUE_TEMPLATE/bug-report.yml?plain=1
2+
name: "\U0001F41B Bug Report"
3+
description: Submit a bug report to help us improve verl
4+
labels: [ "bug" ]
5+
body:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
Thanks for taking the time to fill out this bug report! 🤗
10+
11+
- type: textarea
12+
id: system-info
13+
attributes:
14+
label: System Info
15+
description: Please share your system info with us. You can run the command `python scripts/diagnose.py` and copy-paste its output below.
16+
placeholder: verl version, platform, python version, ...
17+
validations:
18+
required: true
19+
20+
- type: checkboxes
21+
id: information-scripts-examples
22+
attributes:
23+
label: Information
24+
description: 'The problem arises when using:'
25+
options:
26+
- label: "The official example scripts"
27+
- label: "My own modified scripts"
28+
29+
- type: checkboxes
30+
id: information-tasks
31+
attributes:
32+
label: Tasks
33+
description: "The tasks I am working on are:"
34+
options:
35+
- label: "An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)"
36+
- label: "My own task or dataset (give details below)"
37+
38+
- type: textarea
39+
id: reproduction
40+
validations:
41+
required: true
42+
attributes:
43+
label: Reproduction
44+
description: |
45+
Please provide a code sample that reproduces the problem you ran into. It can be a Colab link or just a code snippet.
46+
Please include relevant config information with your code.
47+
If you have code snippets, error messages, stack traces please provide them here as well.
48+
Important! Use code tags to correctly format your code. See https://help.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks#syntax-highlighting
49+
Do not use screenshots, as they are hard to read and (more importantly) don't allow others to copy-and-paste your code.
50+
51+
placeholder: |
52+
Steps to reproduce the behavior:
53+
54+
1.
55+
2.
56+
3.
57+
58+
59+
- type: textarea
60+
id: expected-behavior
61+
validations:
62+
required: true
63+
attributes:
64+
label: Expected behavior
65+
description: "A clear and concise description of what you would expect to happen."

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
blank_issues_enabled: true
2+
version: 0.1
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
# modified from https://github.com/huggingface/transformers/blob/main/.github/ISSUE_TEMPLATE/feature-request.yml?plain=1
2+
name: "\U0001F680 Feature request"
3+
description: Submit a proposal/request for a new verl feature
4+
labels: [ "Feature request" ]
5+
body:
6+
- type: textarea
7+
id: feature-request
8+
validations:
9+
required: true
10+
attributes:
11+
label: Feature request
12+
description: |
13+
A clear and concise description of the feature proposal. Please provide a link to the paper and code in case they exist.
14+
15+
- type: textarea
16+
id: motivation
17+
validations:
18+
required: true
19+
attributes:
20+
label: Motivation
21+
description: |
22+
Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too.
23+
24+
25+
- type: textarea
26+
id: contribution
27+
validations:
28+
required: true
29+
attributes:
30+
label: Your contribution
31+
description: |
32+
Is there any way that you could help, e.g. by submitting a PR? Make sure to read the CONTRIBUTING.MD [readme](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md)

.github/workflows/.deprecate/e2e_ppo_trainer.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
- name: Prepare gsm8k dataset with tool
9090
run: |
9191
ray stop --force
92-
python3 examples/data_preprocess/gsm8k_multiturn_w_tool.py --local_dir $HOME/data/gsm8k_verl_sgl_multi_turn_preprocessed
92+
python3 examples/data_preprocess/gsm8k_multiturn_w_tool.py --local_save_dir $HOME/data/gsm8k_verl_sgl_multi_turn_preprocessed
9393
- name: Running GSM8K with tool E2E training tests on 8 L20 GPUs with rmpad using function rm and save ckpt with sglang
9494
run: |
9595
ray stop --force

.github/workflows/doc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ jobs:
7474
python-version: ${{ matrix.python-version }}
7575
- name: Install the current repository
7676
run: |
77-
pip install -e .[test]
77+
pip install -e .[test] --no-deps
7878
pip install -r docs/requirements-docs.txt
7979
8080
- name: Run doc make html

.github/workflows/e2e_ascend.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,11 @@ jobs:
143143
ray stop --force
144144
bash tests/special_npu/run_qwen2_5_05b_dapo.sh
145145
rm -rf $HOME/ckpts
146+
- name: Running gsm8k e2e qwen3 training tests with GRPO on ASCEND NPU
147+
run: |
148+
ray stop --force
149+
bash tests/special_npu/run_qwen3_06b_grpo.sh
150+
rm -rf $HOME/ckpts
146151
- name: Running gsm8k e2e training tests with GRPO MindSpeed on ASCEND NPU
147152
run: |
148153
ray stop --force
@@ -153,4 +158,3 @@ jobs:
153158
run: |
154159
ray stop --force
155160
pytest -s -x tests/utils/test_special_mstx_profile.py
156-

.github/workflows/e2e_ppo_trainer_megatron_sglang.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,7 @@ jobs:
284284
- name: Running GSM8K E2E training tests with 3D parallelism on 8 L20 GPUs with Megatron (DeepSeek)
285285
run: |
286286
ray stop --force
287+
MEGATRON_CI_DISABLE_EXPANDABLE_SEGMENTS=1 \
287288
ADV_ESTIMATOR=grpo USE_DUMMY_MODEL=True DUMMY_MODEL_CONFIG_PATH=tests/special_e2e/ppo_trainer/expert_parallel/qwen2moe_minimal.json \
288289
PPO_MAX_TOKEN_LEN=512 FWD_MAX_TOKEN_LEN=512 \
289290
MAX_PROMPT_LENGTH=256 MAX_RESPONSE_LENGTH=256 \

.github/workflows/e2e_sft.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ permissions:
7070
contents: read
7171

7272
env:
73-
IMAGE: "verl-ci-cn-beijing.cr.volces.com/verlai/verl:base-verl0.5-cu126-cudnn9.8-torch2.7.1-fa2.7.4"
73+
IMAGE: "verl-ci-cn-beijing.cr.volces.com/verlai/verl:app-verl0.5-transformers4.55.4-sglang0.4.10.post2-mcore0.13.0-te2.2"
7474
DYNAMIC_RUNNER_ENDPOINT: "https://sd10g3clalm04ug7alq90.apigateway-cn-beijing.volceapi.com/runner"
7575

7676
jobs:
@@ -139,6 +139,14 @@ jobs:
139139
ray stop --force
140140
LORA_RANK=32 RESUME_MODE=auto TOTAL_TRAIN_STEP=2 bash tests/special_e2e/sft/run_sft.sh
141141
# TODO: multiturn
142+
- name: Prepare gsm8k dataset
143+
run: |
144+
ray stop --force
145+
python3 examples/data_preprocess/gsm8k_multiturn_sft.py
146+
- name: Running GSM8K E2E training tests with multiturn and various configs and compare results
147+
run: |
148+
bash tests/special_e2e/sft/test_sft_engine_all.sh
149+
142150
143151
cleanup:
144152
runs-on: ubuntu-latest

.github/workflows/gpu_unit_tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ jobs:
100100
# Disable requests to avoid network errors
101101
- name: Run all GPU unit tests
102102
run: |
103-
pytest -s -x --ignore-glob="*test_special_*.py" --ignore-glob='*on_cpu.py' --ignore-glob="*test_vllm*" --ignore-glob="*_sglang*" --ignore-glob="*_hf_rollout*" --ignore-glob="tests/models/" --ignore-glob='tests/special*' --ignore-glob="tests/experimental" tests/
103+
pytest -s -x --ignore-glob="*test_special_*.py" --ignore-glob='*on_cpu.py' --ignore-glob="*test_vllm*" --ignore-glob="*_sglang*" --ignore-glob="*_hf_rollout*" --ignore-glob="tests/models/" --ignore-glob='tests/special*' --ignore-glob="tests/experimental" --ignore-glob="tests/workers/reward_model" tests/
104104
- name: Testing LinearCrossEntropyTP Correctness, Computation Time and Memory Consumption
105105
run: |
106106
LOW_MEMORY=True torchrun --standalone --nnodes=1 --nproc-per-node=8 tests/utils/test_special_linear_cross_entropy_tp.py

0 commit comments

Comments
 (0)