Skip to content

Commit ece8fc4

Browse files
committed
Fix types/node version issue
1 parent 565aa71 commit ece8fc4

File tree

4 files changed

+472
-469
lines changed

4 files changed

+472
-469
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
"build:prod": "lerna run build:prod",
2323
"build:test": "lerna run build:test",
2424
"clean": "lerna run clean",
25-
"eslint": "eslint . --ext .ts,.tsx,.js,.jsx --fix",
26-
"eslint:check": "eslint . --ext .ts,.tsx,.js,.jsx",
25+
"eslint": "eslint . --ext .ts,.tsx --fix",
26+
"eslint:check": "eslint . --ext .ts,.tsx",
2727
"install": "lerna bootstrap",
2828
"prettier": "prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
2929
"prettier:check": "prettier --list-different \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",

packages/voila/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"@babel/core": "^7.2.2",
4747
"@babel/preset-env": "^7.3.1",
4848
"@jupyterlab/builder": "^3.0.0",
49-
"@types/node": "^18.8.3",
49+
"@types/node": "~18.8.3",
5050
"babel-loader": "^8.0.5",
5151
"css-loader": "^6.7.2",
5252
"file-loader": "^6.2.0",

voila/handler.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ async def get_generator(self, path=None):
8686
return
8787

8888
cwd = os.path.dirname(notebook_path)
89-
print("#########", cwd)
9089
# Adding request uri to kernel env
9190
request_info = {}
9291
request_info[ENV_VARIABLE.SCRIPT_NAME] = self.request.path
@@ -258,7 +257,6 @@ async def put_html():
258257

259258
@tornado.web.authenticated
260259
async def get(self, path=None):
261-
print("OPATH", path)
262260
gen = self.get_generator(path=path)
263261
async for html in gen:
264262
self.write(html)

0 commit comments

Comments
 (0)