Skip to content

Commit cd8ed11

Browse files
authored
Merge pull request #1014 from trungleduc/fix-ci
Fix failed tests on CI
2 parents b29251d + e1be3ef commit cd8ed11

File tree

5 files changed

+4
-5
lines changed

5 files changed

+4
-5
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030

3131
- name: Install Dependencies
3232
run: |
33-
python -m pip install -U pip jupyterlab~=3.0 jupyter_packaging~=0.10
33+
python -m pip install -U pip jupyterlab~=3.0 jupyter_packaging~=0.10 'nbclassic!=0.3.3'
3434
3535
- name: Install the Voilà Preview JupyterLab extension
3636
run: |

.github/workflows/ui-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
4747
- name: Install dependencies
4848
run: |
49-
python -m pip install --upgrade pip jupyterlab~=3.0 numpy bqplot matplotlib ipympl ipyvolume scipy
49+
python -m pip install --upgrade pip jupyterlab~=3.0 numpy bqplot matplotlib ipympl==0.8.0 ipyvolume scipy
5050
python -m pip install ".[test]"
5151
jlpm
5252
jlpm build

tests/app/preheat_activation_test.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@ async def test_render_time_with_multiple_requests(http_server_client,
6464
wait=wait)
6565
time_list.append(time)
6666

67-
assert max(time_list) > TIME_THRESHOLD # Render time for a normal kernel
68-
assert min(time_list) < TIME_THRESHOLD # Render time for a preheated kernel
67+
assert time_list[1] > time_list[0] # Render time for a normal kernel is bigger than a a preheated kernel
6968

7069

7170
async def test_request_with_query(http_server_client, base_url):

ui-tests/tests/voila.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ test.describe('Voila performance Tests', () => {
106106
const testFunction = async () => {
107107
await page.goto(`render/${notebookName}.ipynb`);
108108
await page.waitForSelector(
109-
'div.jupyter-widgets.jupyter-matplotlib-canvas-container'
109+
'div.jupyter-widgets.jupyter-matplotlib-canvas-container canvas'
110110
);
111111
};
112112
await addBenchmarkToTest(notebookName, testFunction, testInfo, browserName);
123 Bytes
Loading

0 commit comments

Comments
 (0)