Skip to content

Commit c49cfc8

Browse files
authored
Inject react-dom in the shared scope (#1320)
1 parent 3783b3b commit c49cfc8

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

packages/voila/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
"@lumino/signaling": "^1.7.2",
4141
"@lumino/virtualdom": "^1.11.2",
4242
"@lumino/widgets": "^1.26.2",
43-
"react": "^17.0.1"
43+
"react": "^17.0.1",
44+
"react-dom": "^17.0.1"
4445
},
4546
"devDependencies": {
4647
"@babel/core": "^7.2.2",

packages/voila/src/main.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212

1313
// Inspired by: https://github.com/jupyterlab/jupyterlab/blob/master/dev_mode/index.js
1414

15+
// Inject some packages in the shared scope
16+
import 'react-dom';
17+
1518
import { PageConfig, URLExt } from '@jupyterlab/coreutils';
1619

1720
import { VoilaApp } from './app';

0 commit comments

Comments
 (0)