Skip to content

Commit 9855753

Browse files
committed
remove unused code
1 parent 4a1b94c commit 9855753

File tree

5 files changed

+3
-174
lines changed

5 files changed

+3
-174
lines changed

packages/voila/src/plugins/outputs/plugins.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,7 @@ import { Widget } from '@lumino/widgets';
1616

1717
import { VoilaApp } from '../../app';
1818
import { RenderedCells } from './renderedcells';
19-
import {
20-
createOutputArea,
21-
createSkeleton,
22-
executeCode,
23-
getExecutionURL,
24-
handleExecutionResult,
25-
IExecutionMessage,
26-
IReceivedWidgetModel
27-
} from './tools';
28-
import { SimplifiedOutputArea } from '@jupyterlab/outputarea';
19+
import { createOutputArea, createSkeleton, executeCode } from './tools';
2920

3021
/**
3122
* The plugin that renders outputs.

tsconfigbase.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"moduleResolution": "node",
1111
"noEmitOnError": true,
1212
"noImplicitAny": true,
13-
"noUnusedLocals": false,
13+
"noUnusedLocals": true,
1414
"preserveWatchOutput": true,
1515
"resolveJsonModule": true,
1616
"strict": true,

voila/app.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222

2323
from .tornado.kernel_websocket_handler import VoilaKernelWebsocketHandler
2424

25-
from .tornado.execution_request_handler import ExecutionRequestHandler
26-
2725
from .tornado.contentshandler import VoilaContentsHandler
2826

2927
from urllib.parse import urljoin
@@ -790,15 +788,6 @@ def init_handlers(self) -> List:
790788
RequestInfoSocketHandler,
791789
)
792790
)
793-
if self.voila_configuration.progressive_rendering:
794-
handlers.append(
795-
(
796-
url_path_join(
797-
self.server_url, r"/voila/execution/%s" % _kernel_id_regex
798-
),
799-
ExecutionRequestHandler,
800-
)
801-
)
802791
# Serving JupyterLab extensions
803792
handlers.append(
804793
(

voila/server_extension.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
from jupyter_core.paths import jupyter_config_path
1919
from jupyter_server.serverapp import ServerApp
2020

21-
from .tornado.execution_request_handler import ExecutionRequestHandler, JUPYTER_SERVER_2
2221
from .tornado.contentshandler import VoilaContentsHandler
2322
from traitlets.config import (
2423
JSONFileConfigLoader,
@@ -187,13 +186,7 @@ def _load_jupyter_server_extension(server_app: ServerApp):
187186
tree_handler_conf,
188187
),
189188
]
190-
if JUPYTER_SERVER_2 and voila_configuration.progressive_rendering:
191-
handlers.append(
192-
(
193-
url_path_join(base_url, r"/voila/execution/%s" % _kernel_id_regex),
194-
ExecutionRequestHandler,
195-
)
196-
)
189+
197190
web_app.add_handlers(host_pattern, handlers)
198191

199192
web_app.add_handlers(

voila/tornado/execution_request_handler.py

Lines changed: 0 additions & 144 deletions
This file was deleted.

0 commit comments

Comments
 (0)