Skip to content

Commit 5dcdb80

Browse files
feat: support for ipywidgets 8 (#1046)
* feat: support for ipywidgets 8 * Update to `@jupyter-widgets` 8 final packages * yarn deduplicate * Bump `ipympl` test dependency * Update reference snapshots * Install `ipyvolume` from the branch * Update ipyvolume snapshot * Update ipyvolume snapshot Co-authored-by: Jeremy Tuloup <[email protected]>
1 parent b588c06 commit 5dcdb80

File tree

11 files changed

+524
-509
lines changed

11 files changed

+524
-509
lines changed

packages/voila/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
"main": "lib/index.js",
99
"browserslist": ">0.8%, not ie 11, not op_mini all, not dead",
1010
"dependencies": {
11-
"@jupyter-widgets/base": "^4.1.0",
12-
"@jupyter-widgets/controls": "^3.1.0",
13-
"@jupyter-widgets/jupyterlab-manager": "^3.1.0",
11+
"@jupyter-widgets/base": "^6.0.1",
12+
"@jupyter-widgets/controls": "^5.0.1",
13+
"@jupyter-widgets/jupyterlab-manager": "^5.0.3",
1414
"@jupyterlab/application": "^3.0.0",
1515
"@jupyterlab/apputils": "^3.0.0",
1616
"@jupyterlab/coreutils": "^5.0.0",

packages/voila/src/manager.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,9 @@ export class WidgetManager extends JupyterLabManager {
111111
const model = await this.get_model(model_id);
112112
const widgetel = document.createElement('div');
113113
viewtag.parentElement.insertBefore(widgetel, viewtag);
114+
const view = await this.create_view(model);
114115
// TODO: fix typing
115-
await this.display_model(undefined as any, model, {
116+
await this.display_view(undefined as any, view, {
116117
el: widgetel
117118
});
118119
} catch (error) {
@@ -131,7 +132,7 @@ export class WidgetManager extends JupyterLabManager {
131132

132133
async display_view(msg: any, view: any, options: any): Promise<Widget> {
133134
if (options.el) {
134-
LuminoWidget.Widget.attach(view.pWidget, options.el);
135+
LuminoWidget.Widget.attach(view.luminoWidget, options.el);
135136
}
136137
if (view.el) {
137138
view.el.setAttribute('data-voila-jupyter-widget', '');

setup.cfg

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ visual_test =
6262
jupyterlab~=3.0
6363
bqplot
6464
scipy
65-
ipympl==0.8.7
66-
ipyvolume
65+
ipympl==0.9.2
66+
ipyvolume @ git+https://github.com/jtpio/ipyvolume@ipywidgets-8
6767
jupyterlab_miami_nights==0.3.2
6868

6969
[options.entry_points]
40.5 KB
Loading
41.5 KB
Loading
21.9 KB
Loading
11.4 KB
Loading
14.2 KB
Loading
19.4 KB
Loading
6.58 KB
Loading

0 commit comments

Comments
 (0)