Skip to content

Commit 091b3b7

Browse files
committed
Fix report name + output widget
1 parent b267e79 commit 091b3b7

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

.github/workflows/ui-tests.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -76,38 +76,38 @@ jobs:
7676
- name: Set test report name for progressive rendering
7777
if: always() && matrix.progressive_rendering == true
7878
run: |
79-
echo "TEST_REPORT_NAME=progressive-voila-test-report-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
80-
echo "TEST_ASSETS_NAME=progressive-voila-test-assets-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
81-
echo "TEST_BENCHMARK_NAME=progressive-voila-test-benchmark-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
79+
echo "TEST_REPORT_NAME=progressive-voila-test-report-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
80+
echo "TEST_ASSETS_NAME=progressive-voila-test-assets-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
81+
echo "TEST_BENCHMARK_NAME=progressive-voila-test-benchmark-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
8282
8383
- name: Set test report name for non-progressive rendering
8484
if: always() && matrix.progressive_rendering == false
8585
run: |
86-
echo "TEST_REPORT_NAME=voila-test-report-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
87-
echo "TEST_ASSETS_NAME=voila-test-assets-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
88-
echo "TEST_BENCHMARK_NAME=voila-test-benchmark-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
86+
echo "TEST_REPORT_NAME=voila-test-report-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
87+
echo "TEST_ASSETS_NAME=voila-test-assets-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
88+
echo "TEST_BENCHMARK_NAME=voila-test-benchmark-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
8989
9090
- name: Upload Playwright Test assets
9191
if: always()
9292
uses: actions/upload-artifact@v4
9393
with:
94-
name: ${{ env.TEST_ASSETS_NAME }}${{ matrix.ipywidgets }}
94+
name: ${{ env.TEST_ASSETS_NAME }}
9595
path: |
9696
ui-tests/test-results
9797
9898
- name: Upload Playwright Benchmark report
9999
if: always()
100100
uses: actions/upload-artifact@v4
101101
with:
102-
name: ${{ env.TEST_BENCHMARK_NAME }}${{ matrix.ipywidgets }}
102+
name: ${{ env.TEST_BENCHMARK_NAME }}
103103
path: |
104104
ui-tests/benchmark-results
105105
106106
- name: Upload Playwright Test report
107107
if: always()
108108
uses: actions/upload-artifact@v4
109109
with:
110-
name: ${{ env.TEST_REPORT_NAME }}${{ matrix.ipywidgets }}
110+
name: ${{ env.TEST_REPORT_NAME }}
111111
path: |
112112
ui-tests/playwright-report
113113

packages/widgets_manager7/src/index.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {
2020
StyleView
2121
} from '@jupyter-widgets/base';
2222
import { JUPYTER_CONTROLS_VERSION } from '@jupyter-widgets/controls/lib/version';
23-
import { WidgetRenderer } from '@jupyter-widgets/jupyterlab-manager';
23+
import { WidgetRenderer, output } from '@jupyter-widgets/jupyterlab-manager';
2424
import {
2525
JupyterFrontEnd,
2626
JupyterFrontEndPlugin
@@ -168,6 +168,12 @@ const widgetManager: JupyterFrontEndPlugin<IJupyterWidgetRegistry> = {
168168
}
169169
});
170170

171+
manager.register({
172+
name: '@jupyter-widgets/output',
173+
version: output.OUTPUT_WIDGET_VERSION,
174+
exports: output as any
175+
});
176+
171177
app.started.then(async () => {
172178
await manager._loadFromKernel();
173179
});

0 commit comments

Comments
 (0)